Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1466875

Re: [PATCH 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform

Show all headers | View raw

Hello.

On 08/20/2016 11:32 PM, Randy Li wrote:

> On the rk3288 USB host-only port (the one that's not the OTG-enabled
> port) the PHY can get into a bad state when a wakeup is asserted (not
> just a wakeup from full system suspend but also a wakeup from
> autosuspend).
>
> We can get the PHY out of its bad state by asserting its "port reset",
> but unfortunately that seems to assert a reset onto the USB bus so it
> could confuse things if we don't actually deenumerate / reenumerate the
> device.
>
> We can also get the PHY out of its bad state by fully resetting it using
> the reset from the CRU (clock reset unit) in chip, which does a more full
> reset.  The CRU-based reset appears to actually cause devices on the bus
> to be removed and reinserted, which fixes the problem (albeit in a hacky
> way).
>
> It's unfortunate that we need to do a full re-enumeration of devices at
> wakeup time, but this is better than alternative of letting the bus get
> wedged.
>
> The original patches came from Doug Anderson <dianders@chromium.org>.
>
> Signed-off-by: Randy Li <ayaka@soulik.info>
> ---
>  drivers/usb/dwc2/core_intr.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/drivers/usb/dwc2/core_intr.c b/drivers/usb/dwc2/core_intr.c
> index d85c5c9..c31c3fe 100644
> --- a/drivers/usb/dwc2/core_intr.c
> +++ b/drivers/usb/dwc2/core_intr.c
[...]
> @@ -379,6 +380,14 @@ static void dwc2_handle_wakeup_detected_intr(struct dwc2_hsotg *hsotg)
>  			/* Restart the Phy Clock */
>  			pcgcctl &= ~PCGCTL_STOPPCLK;
>  			dwc2_writel(pcgcctl, hsotg->regs + PCGCTL);
> +
> +			/* It is a quirk in Rockchip RK3288, causing by
> +			 * a hardware bug. This will propagate out and
> +			 * eventually we'll re-enumerate the device.
> +			 * Not great but the best we can do */

   The preferred multi-line comment style is this:

/*
  * bla
  * bla
  */

    Yours is close. :-)

[...]

MBR, Sergei

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform Randy Li <ayaka@soulik.info> - 2016-08-20 22:50 +0200
  Re: [PATCH 3/4] usb: dwc2: assert phy reset when waking up in rk3288  platform Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-08-20 23:40 +0200
    [PATCH 4/4] ARM: dts: rockchip: Point rk3288 dwc2 usb at the full PHY reset Randy Li <ayaka@soulik.info> - 2016-08-21 10:00 +0200
      Re: [PATCH 4/4] ARM: dts: rockchip: Point rk3288 dwc2 usb at the full  PHY reset Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-08-21 13:10 +0200
        Re: [PATCH 4/4] ARM: dts: rockchip: Point rk3288 dwc2 usb at the full  PHY reset ayaka <ayaka@soulik.info> - 2016-08-21 14:30 +0200
          Re: [PATCH 4/4] ARM: dts: rockchip: Point rk3288 dwc2 usb at the full  PHY reset Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-08-22 12:40 +0200
    [PATCH 2/4] phy: rockchip-usb: use rockchip_usb_phy_reset to reset phy during wakeup Randy Li <ayaka@soulik.info> - 2016-08-21 10:00 +0200
      Re: [PATCH 2/4] phy: rockchip-usb: use rockchip_usb_phy_reset to  reset phy during wakeup Rob Herring <robh@kernel.org> - 2016-08-23 20:20 +0200
    [PATCH 1/4] phy: Add reset callback Randy Li <ayaka@soulik.info> - 2016-08-21 10:00 +0200
    [PATCH 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform Randy Li <ayaka@soulik.info> - 2016-08-21 10:00 +0200
    [PATCH 0/4 v5] usb: dwc2: fix the usb host for host port at RK32 Randy Li <ayaka@soulik.info> - 2016-08-21 10:00 +0200
    [RESEND PATCH 4/4] ARM: dts: rockchip: Point rk3288 dwc2 usb at the full PHY reset Randy Li <ayaka@soulik.info> - 2016-08-21 21:40 +0200
    [RESEND PATCH 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform Randy Li <ayaka@soulik.info> - 2016-08-21 21:40 +0200
      Re: [RESEND PATCH 3/4] usb: dwc2: assert phy reset when waking up in  rk3288 platform John Youn <John.Youn@synopsys.com> - 2016-08-23 22:50 +0200
        Re: [RESEND PATCH 3/4] usb: dwc2: assert phy reset when waking up in  rk3288 platform Randy Li <randy.li@rock-chips.com> - 2016-08-24 11:00 +0200

csiph-web