Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1467654

Re: [PATCH 1/2] arm64: kernel: Add SMC Session ID to results

Show all headers | View raw

On Mon, Aug 22, 2016 at 02:43:14PM +0100, Will Deacon wrote:
> On Sat, Aug 20, 2016 at 12:51:13AM -0500, Andy Gross wrote:
> > This patch adds the SMC Session ID to the results passed back from SMC
> > calls.  The Qualcomm SMC implementation provides for interrupted SMC
> > functions.  When this occurs, the SMC call will return a session ID that
> > is required to be used when resuming the interrupted SMC call.
> > 
> > Signed-off-by: Andy Gross <andy.gross@linaro.org>
> > ---
> >  arch/arm64/kernel/asm-offsets.c | 1 +
> >  arch/arm64/kernel/smccc-call.S  | 1 +
> >  include/linux/arm-smccc.h       | 4 +++-
> >  3 files changed, 5 insertions(+), 1 deletion(-)
> 
> [...]
> 
> > diff --git a/include/linux/arm-smccc.h b/include/linux/arm-smccc.h
> > index b5abfda..82d919f 100644
> > --- a/include/linux/arm-smccc.h
> > +++ b/include/linux/arm-smccc.h
> > @@ -63,18 +63,20 @@
> >  /**
> >   * struct arm_smccc_res - Result from SMC/HVC call
> >   * @a0-a3 result values from registers 0 to 3
> > + * @a6 Session ID register (optional)
> >   */
> >  struct arm_smccc_res {
> >  	unsigned long a0;
> >  	unsigned long a1;
> >  	unsigned long a2;
> >  	unsigned long a3;
> > +	unsigned long a6;
> >  };
> >  
> >  /**
> >   * arm_smccc_smc() - make SMC calls
> >   * @a0-a7: arguments passed in registers 0 to 7
> > - * @res: result values from registers 0 to 3
> > + * @res: result values from registers 0 to 3 and optional register 6
> 
> AFAICT from reading the SMCCC spec, parameter register 6 is "Unpredictable,
> Scratch registers" in return state, so I don't think this is correct.
> 
> What am I missing?

In the case of Qualcomm's implementation, they return a value in register 6 that
may or may not be used in subsequent calls.  If I want to leverage the arm_smccc
functions, then I need to extend them to include the optional return value.  The
downside to this is that everyone who uses this is exposed to it.

Regards,

Andy

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] Qualcomm SMCCC Session ID Support Andy Gross <andy.gross@linaro.org> - 2016-08-20 08:00 +0200
  [PATCH 1/2] arm64: kernel: Add SMC Session ID to results Andy Gross <andy.gross@linaro.org> - 2016-08-20 08:00 +0200
    Re: [PATCH 1/2] arm64: kernel: Add SMC Session ID to results Will Deacon <will.deacon@arm.com> - 2016-08-22 15:50 +0200
      Re: [PATCH 1/2] arm64: kernel: Add SMC Session ID to results Andy Gross <andy.gross@linaro.org> - 2016-08-22 16:10 +0200
        Re: [PATCH 1/2] arm64: kernel: Add SMC Session ID to results Will Deacon <will.deacon@arm.com> - 2016-08-22 17:00 +0200
          Re: [PATCH 1/2] arm64: kernel: Add SMC Session ID to results Andy Gross <andy.gross@linaro.org> - 2016-08-22 17:20 +0200
            Re: [PATCH 1/2] arm64: kernel: Add SMC Session ID to results Andy Gross <andy.gross@linaro.org> - 2016-08-23 14:50 +0200
          Re: [PATCH 1/2] arm64: kernel: Add SMC Session ID to results Stephen Boyd <sboyd@codeaurora.org> - 2016-08-23 02:40 +0200
            Re: [PATCH 1/2] arm64: kernel: Add SMC Session ID to results Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-08-23 11:10 +0200
            Re: [PATCH 1/2] arm64: kernel: Add SMC Session ID to results Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-08-23 12:40 +0200
              Re: [PATCH 1/2] arm64: kernel: Add SMC Session ID to results Andy Gross <andy.gross@linaro.org> - 2016-08-23 14:40 +0200
    Re: [PATCH 1/2] arm64: kernel: Add SMC Session ID to results Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-08-24 20:30 +0200
  [PATCH 2/2] firmware: qcom: scm: Fix interrupted SCM calls Andy Gross <andy.gross@linaro.org> - 2016-08-20 08:00 +0200

csiph-web