Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1467573

Re: [PATCH 2/2] proc: task_mmu: Reduce output processing cpu time

Show all headers | View raw

On Mon 22-08-16 01:30:14, Joe Perches wrote:
> On Mon, 2016-08-22 at 01:00 -0700, Joe Perches wrote:
> > On Mon, 2016-08-22 at 09:24 +0200, Michal Hocko wrote:
> > > On Sat 20-08-16 01:00:17, Joe Perches wrote:
> []
> > > > static int proc_maps_open(struct inode *inode, struct file *file,
> > > >  			const struct seq_operations *ops, int psize)
> > > >  {
> > > > -	struct proc_maps_private *priv = __seq_open_private(file, ops, psize);
> > > > +	struct proc_maps_private *priv;
> > > > +	struct mm_struct *mm;
> > > > +
> > > > +	mm = proc_mem_open(inode, PTRACE_MODE_READ);
> > > > +	if (IS_ERR(mm))
> > > > +		return PTR_ERR(mm);
> > > >  
> > > > +	priv = __seq_open_private_bufsize(file, ops, psize,
> > > > +					  mm && mm->map_count ?
> > > > +					  mm->map_count * 0x300 : PAGE_SIZE);
> > > NAK to this!
> > > 
> > > Seriously, this just gives any random user access to user
> > > defined amount of memory which not accounted, not reclaimable and a
> > > potential consumer of any higher order blocks.
> > I completely disagree here with your rationale here.
> 
> And with further review and your comment above, I withdraw this patch.

So you've made me look into that code. I can imagine how it is easy to
to get confused here. The important part is that m->count is reset after
each ->show(). So traverse() same as seq_read only grows the buffer if
a single show doesn't fit in.

That being said, should I repost my rebased patches or do you plan to
repost your patch? I do not want spam people with another version if
you do not like it.
-- 
Michal Hocko
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] proc, smaps: reduce printing overhead Michal Hocko <mhocko@kernel.org> - 2016-08-18 13:40 +0200
  Re: [PATCH] proc, smaps: reduce printing overhead Joe Perches <joe@perches.com> - 2016-08-18 15:30 +0200
    Re: [PATCH] proc, smaps: reduce printing overhead Joe Perches <joe@perches.com> - 2016-08-18 16:50 +0200
    Re: [PATCH] proc, smaps: reduce printing overhead Joe Perches <joe@perches.com> - 2016-08-18 16:50 +0200
      Re: [PATCH] proc, smaps: reduce printing overhead Joe Perches <joe@perches.com> - 2016-08-19 03:00 +0200
        Re: [PATCH] proc, smaps: reduce printing overhead Michal Hocko <mhocko@kernel.org> - 2016-08-19 03:40 +0200
      Re: [PATCH] proc, smaps: reduce printing overhead Michal Hocko <mhocko@kernel.org> - 2016-08-19 06:00 +0200
    Re: [PATCH] proc, smaps: reduce printing overhead Michal Hocko <mhocko@kernel.org> - 2016-08-18 16:50 +0200
      Re: [PATCH] proc, smaps: reduce printing overhead Michal Hocko <mhocko@kernel.org> - 2016-08-18 16:50 +0200
  [PATCH 2/2] proc, smaps: reduce printing overhead Michal Hocko <mhocko@kernel.org> - 2016-08-19 12:20 +0200
  [PATCH 1/2] proc, meminfo: abstract show_val_kb Michal Hocko <mhocko@kernel.org> - 2016-08-19 12:20 +0200
  [PATCH 0/2] fs, proc: optimize smaps output formatting Michal Hocko <mhocko@kernel.org> - 2016-08-19 12:20 +0200
    Re: [PATCH 0/2] fs, proc: optimize smaps output formatting Joe Perches <joe@perches.com> - 2016-08-19 19:50 +0200
      Re: [PATCH 0/2] fs, proc: optimize smaps output formatting Joe Perches <joe@perches.com> - 2016-08-19 22:20 +0200
      Re: [PATCH 0/2] fs, proc: optimize smaps output formatting Michal Hocko <mhocko@kernel.org> - 2016-08-20 09:30 +0200
        Re: [PATCH 0/2] fs, proc: optimize smaps output formatting Joe Perches <joe@perches.com> - 2016-08-20 10:00 +0200
        [PATCH 0/2] seq: Speed up /proc/<pid>/smaps Joe Perches <joe@perches.com> - 2016-08-20 10:10 +0200
        [PATCH 1/2] seq_file: Add __seq_open_private_bufsize for seq file_operation sizes Joe Perches <joe@perches.com> - 2016-08-20 10:10 +0200
        [PATCH 2/2] proc: task_mmu: Reduce output processing cpu time Joe Perches <joe@perches.com> - 2016-08-20 10:10 +0200
          Re: [PATCH 2/2] proc: task_mmu: Reduce output processing cpu time Michal Hocko <mhocko@kernel.org> - 2016-08-22 09:30 +0200
            Re: [PATCH 2/2] proc: task_mmu: Reduce output processing cpu time Joe Perches <joe@perches.com> - 2016-08-22 10:10 +0200
              Re: [PATCH 2/2] proc: task_mmu: Reduce output processing cpu time Joe Perches <joe@perches.com> - 2016-08-22 10:40 +0200
                Re: [PATCH 2/2] proc: task_mmu: Reduce output processing cpu time Michal Hocko <mhocko@kernel.org> - 2016-08-22 14:10 +0200
  Re: [PATCH] proc, smaps: reduce printing overhead Michal Hocko <mhocko@kernel.org> - 2016-08-23 18:20 +0200

csiph-web