Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1467589

Re: [PATCH] iommu/vt-d: Fix modify_irte NULL pointer

Show all headers | View raw

On Mon, 22 Aug 2016, Wanpeng Li wrote:

> From: Wanpeng Li <wanpeng.li@hotmail.com>
> 
> native_smp_prepare_cpus
>   -> default_setup_apic_routing
>     -> enable_IR_x2apic
>       -> irq_remapping_prepare
>         -> intel_prepare_irq_remapping
>           -> parse_ioapics_under_ir   => return 0
> 		    -> ir_parse_ioapic_hpet_scope
> 		      -> ir_parse_one_ioapic_scope 	
>           -> intel_setup_irq_remapping		  
 
> IR table is setup even if noapic boot parameter is added.
> index ac59692..f1cb7c6 100644
> --- a/drivers/iommu/intel_irq_remapping.c
> +++ b/drivers/iommu/intel_irq_remapping.c
> @@ -854,6 +854,9 @@ static int ir_parse_one_ioapic_scope(struct acpi_dmar_device_scope *scope,
>  	count = (scope->length - sizeof(struct acpi_dmar_device_scope))
>  		/ sizeof(struct acpi_dmar_pci_path);
>  
> +	if (skip_ioapic_setup)
> +		return -ENODEV;

Why are you adding this in the iommu code? We should not call any of the apic
functions when apic is disabled.

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] iommu/vt-d: Fix modify_irte NULL pointer Wanpeng Li <kernellwp@gmail.com> - 2016-08-22 14:30 +0200
  Re: [PATCH] iommu/vt-d: Fix modify_irte NULL pointer Thomas Gleixner <tglx@linutronix.de> - 2016-08-22 14:50 +0200
    Re: [PATCH] iommu/vt-d: Fix modify_irte NULL pointer Wanpeng Li <kernellwp@gmail.com> - 2016-08-22 15:40 +0200

csiph-web