Re: [PATCH] staging/lustre: avoid zero buf for the first time

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging/lustre: avoid zero buf for the first time
Date	2016-08-22 12:10 +0200
Message-ID	<s8Ul4-4Vk-33@gated-at.bofh.it> (permalink)
References	<s8Tfj-42v-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Aug 22, 2016 at 04:46:04PM +0800, Shawn Lin wrote:
> We only need to zero it when repeating in order to
> avoid old garbage. Let's improve it by moving this
> before we repeat the calculation to save some cpu
> cycle.
> 
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>

Have you noticed a change with this in a benchmark?

If not, is it really worth it?

I need an ack from the lustre developers before taking patches like
this...

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging/lustre: avoid zero buf for the first time Shawn Lin <shawn.lin@rock-chips.com> - 2016-08-22 11:00 +0200
  Re: [PATCH] staging/lustre: avoid zero buf for the first time Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-08-22 12:10 +0200

csiph-web