Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1467517
| From | Catalin Marinas <catalin.marinas@arm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC PATCH v2 2/2] arm64 Kconfig: Select gigantic page |
| Date | 2016-08-22 12:10 +0200 |
| Message-ID | <s8Ul3-4Vk-13@gated-at.bofh.it> (permalink) |
| References | <s8NCV-mn-5@gated-at.bofh.it> <s8NMC-EB-1@gated-at.bofh.it> <s8SsV-3Ku-27@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Aug 22, 2016 at 10:03:58AM +0200, Michal Hocko wrote:
> On Mon 22-08-16 10:56:43, Xie Yisheng wrote:
> > Arm64 supports gigantic page after
> > commit 084bd29810a5 ("ARM64: mm: HugeTLB support.")
> > however, it got broken by
> > commit 944d9fec8d7a ("hugetlb: add support for gigantic page
> > allocation at runtime")
> >
> > This patch selects ARCH_HAS_GIGANTIC_PAGE to make this
> > function can be used again.
>
> I haven't double checked that the above commit really broke it but if
> that is the case then
>
> Fixes: 944d9fec8d7a ("hugetlb: add support for gigantic page allocation at runtime")
>
> would be nice as well I guess. I do not think that marking it for stable
> is really necessary considering how long it's been broken and nobody has
> noticed...
I'm not sure that commit broke it. The gigantic functionality introduced
by the above commit was under an #ifdef CONFIG_X86_64. Prior
to that we had a VM_BUG_ON(hstate_is_gigantic(h)).
--
Catalin
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC PATCH v2 0/2] arm64/hugetlb: enable gigantic page Xie Yisheng <xieyisheng1@huawei.com> - 2016-08-22 05:00 +0200
[RFC PATCH v2 2/2] arm64 Kconfig: Select gigantic page Xie Yisheng <xieyisheng1@huawei.com> - 2016-08-22 05:10 +0200
Re: [RFC PATCH v2 2/2] arm64 Kconfig: Select gigantic page Michal Hocko <mhocko@kernel.org> - 2016-08-22 10:10 +0200
Re: [RFC PATCH v2 2/2] arm64 Kconfig: Select gigantic page Catalin Marinas <catalin.marinas@arm.com> - 2016-08-22 12:10 +0200
Re: [RFC PATCH v2 2/2] arm64 Kconfig: Select gigantic page Yisheng Xie <xieyisheng1@huawei.com> - 2016-08-22 13:40 +0200
Re: [RFC PATCH v2 2/2] arm64 Kconfig: Select gigantic page Catalin Marinas <catalin.marinas@arm.com> - 2016-08-22 12:30 +0200
csiph-web