Re: [PATCH] thermal: rcar_thermal: don't call thermal_zone_device_unregister when USE_OF_THERMAL

From	Zhang Rui <rui.zhang@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] thermal: rcar_thermal: don't call thermal_zone_device_unregister when USE_OF_THERMAL
Date	2016-08-22 10:00 +0200
Message-ID	<s8Sjg-3ra-7@gated-at.bofh.it> (permalink)
References	<s8Sjg-3ra-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 一, 2016-08-22 at 03:19 +0000, Kuninori Morimoto wrote:
> From: Bui Duc Phuc <bd-phuc@jinso.co.jp>
> 
> devm_thermal_zone_of_sensor_register() case doesn't need to call
> thermal_zone_device_unregister().
> Otherwise, rcar-thermal can't register thermal zone again after
> rebind.
> This patch fixes it.
> 
> Signed-off-by: Bui Duc Phuc <bd-phuc@jinso.co.jp>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Patch applied.

thanks,
rui
> ---
>  drivers/thermal/rcar_thermal.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/thermal/rcar_thermal.c
> b/drivers/thermal/rcar_thermal.c
> index 4d07644..b5c6442 100644
> --- a/drivers/thermal/rcar_thermal.c
> +++ b/drivers/thermal/rcar_thermal.c
> @@ -419,9 +419,10 @@ static int rcar_thermal_remove(struct
> platform_device *pdev)
>  
>  	rcar_thermal_for_each_priv(priv, common) {
>  		rcar_thermal_irq_disable(priv);
> -		thermal_zone_device_unregister(priv->zone);
>  		if (rcar_use_of_thermal(dev))
>  			thermal_remove_hwmon_sysfs(priv->zone);
> +		else
> +			thermal_zone_device_unregister(priv->zone);
>  	}
>  
>  	pm_runtime_put(dev);

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] thermal: rcar_thermal: don't call  thermal_zone_device_unregister when USE_OF_THERMAL Zhang Rui <rui.zhang@intel.com> - 2016-08-22 10:00 +0200

csiph-web