Re: [PATCH 1/1] drm/gma500: dont expose stack, mrst_lvds_find_best_pll

From	Jani Nikula <jani.nikula@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1] drm/gma500: dont expose stack, mrst_lvds_find_best_pll
Date	2016-08-22 10:40 +0200
Message-ID	<s8SVY-3V6-21@gated-at.bofh.it> (permalink)
References	<s8H4u-4F3-39@gated-at.bofh.it>
Organization	Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw

On Sun, 21 Aug 2016, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> All components of variable clock should be initialized
> to avoid bytes from the kernel stack to be exposed.
>
> Reported-by: Joe Perches <joe@perches.com>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  drivers/gpu/drm/gma500/oaktrail_crtc.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/gma500/oaktrail_crtc.c b/drivers/gpu/drm/gma500/oaktrail_crtc.c
> index 28bd8f3..0277d85 100644
> --- a/drivers/gpu/drm/gma500/oaktrail_crtc.c
> +++ b/drivers/gpu/drm/gma500/oaktrail_crtc.c
> @@ -195,6 +195,7 @@ static bool mrst_lvds_find_best_pll(const struct gma_limit_t *limit,
>  	struct gma_clock_t clock;
>  	int err = target;
>  
> +	memset(clock, 0, sizeof(struct gma_clock_t));

Again, did you actually build this? This is hurting not helping us. It
makes me think you didn't try your other patches either.

BR,
Jani.


>  	memset(best_clock, 0, sizeof(*best_clock));
>  
>  	for (clock.m = limit->m.min; clock.m <= limit->m.max; clock.m++) {

-- 
Jani Nikula, Intel Open Source Technology Center

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] drm/gma500: dont expose stack, mrst_lvds_find_best_pll Heinrich Schuchardt <xypron.glpk@gmx.de> - 2016-08-21 22:00 +0200
  Re: [PATCH 1/1] drm/gma500: dont expose stack, mrst_lvds_find_best_pll Jani Nikula <jani.nikula@linux.intel.com> - 2016-08-22 10:40 +0200

csiph-web