Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1467261

Re: [PATCH 2/2] staging: dgnc: refactor the dgnc_maxcps_room() to improve

Show all headers | View raw

On Fri, Aug 19, 2016 at 10:05:19AM +0900, Daeseok Youn wrote:
> The whole code in dgnc_maxcps_room() function surrounds with
> one if-statement for checking channel's maxcps and buffer size.
> I tried to separate the logic for this function from if-condition.
> 
> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
> ---
>  drivers/staging/dgnc/dgnc_tty.c | 46 +++++++++++++++++++++--------------------
>  1 file changed, 24 insertions(+), 22 deletions(-)

Have you tested this on the hardware?

Until you do, I'm loath to take changes like this, especially as you are
adding more code than you remove :(

sorry,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] staging: dgnc: refactor the dgnc_maxcps_room() to improve Daeseok Youn <daeseok.youn@gmail.com> - 2016-08-19 03:10 +0200
  Re: [PATCH 2/2] staging: dgnc: refactor the dgnc_maxcps_room() to  improve Greg KH <gregkh@linuxfoundation.org> - 2016-08-21 23:30 +0200

csiph-web