Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1467280

Re: [PATCH] staging/rtlwifi: use s8 instead of char

Show all headers | View raw

On Wed, Jun 15, 2016 at 10:35:22PM +0200, Arnd Bergmann wrote:
> Compiling the rtlwifi drivers for ARM with gcc -Wextra warns about lots of
> incorrect code that results from 'char' being unsigned here, e.g.
> 
> staging/rtl8192e/rtl8192e/r8192E_phy.c:1072:36: error: comparison is always false due to limited range of data type [-Werror=type-limits]
> staging/rtl8192e/rtl8192e/r8192E_phy.c:1104:36: error: comparison is always false due to limited range of data type [-Werror=type-limits]
> staging/rtl8192e/rtl8192e/rtl_core.c:1987:16: error: comparison is always false due to limited range of data type [-Werror=type-limits]
> staging/rtl8192e/rtl8192e/rtl_dm.c:782:37: error: comparison is always false due to limited range of data type [-Werror=type-limits]
> staging/rtl8192e/rtl819x_TSProc.c:326:14: error: comparison is always true due to limited range of data type [-Werror=type-limits]
> staging/rtl8192e/rtllib_softmac_wx.c:465:16: error: comparison is always false due to limited range of data type [-Werror=type-limits]
> staging/rtl8192u/r8192U_core.c:4150:16: error: comparison is always false due to limited range of data type [-Werror=type-limits]
> staging/rtl8192u/r8192U_dm.c:646:50: error: comparison is always false due to limited range of data type [-Werror=type-limits]
> 
> This patch changes all uses of 'char' in these drivers that refer to
> 8-bit integers to use 's8' instead, which is signed on all architectures.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/staging/rtl8188eu/core/rtw_ap.c        |  2 +-
>  drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c |  8 ++++----
>  drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c |  2 +-
>  drivers/staging/rtl8192e/rtl8192e/rtl_core.c   |  6 +++---
>  drivers/staging/rtl8192e/rtl8192e/rtl_core.h   |  8 ++++----
>  drivers/staging/rtl8192e/rtl819x_TSProc.c      |  2 +-
>  drivers/staging/rtl8192u/ieee80211/ieee80211.h |  4 ++--
>  drivers/staging/rtl8192u/r8192U.h              |  4 ++--
>  drivers/staging/rtl8192u/r8192U_core.c         | 14 +++++++-------
>  9 files changed, 25 insertions(+), 25 deletions(-)

Doesn't apply anymore as I think you sent parts of this to me already :(

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] staging/rtlwifi: use s8 instead of char Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-08-21 23:40 +0200

csiph-web