Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1467193

[PATCH 1/1] drm/amdgpu/gmc7: remove dead code

From Heinrich Schuchardt <xypron.glpk@gmx.de>
Newsgroups linux.kernel
Subject [PATCH 1/1] drm/amdgpu/gmc7: remove dead code
Date 2016-08-21 20:10 +0200
Message-ID <s8Fm1-3If-5@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


In an if block for (running == 0) running cannot be non-zero.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c
index 0b0f086..1239463 100644
--- a/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c
@@ -203,11 +203,6 @@ static int gmc_v7_0_mc_load_microcode(struct amdgpu_device *adev)
 	running = REG_GET_FIELD(RREG32(mmMC_SEQ_SUP_CNTL), MC_SEQ_SUP_CNTL, RUN);
 
 	if (running == 0) {
-		if (running) {
-			blackout = RREG32(mmMC_SHARED_BLACKOUT_CNTL);
-			WREG32(mmMC_SHARED_BLACKOUT_CNTL, blackout | 1);
-		}
-
 		/* reset the engine and set to writable */
 		WREG32(mmMC_SEQ_SUP_CNTL, 0x00000008);
 		WREG32(mmMC_SEQ_SUP_CNTL, 0x00000010);
@@ -239,9 +234,6 @@ static int gmc_v7_0_mc_load_microcode(struct amdgpu_device *adev)
 				break;
 			udelay(1);
 		}
-
-		if (running)
-			WREG32(mmMC_SHARED_BLACKOUT_CNTL, blackout);
 	}
 
 	return 0;
-- 
2.1.4

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH 1/1] drm/amdgpu/gmc7: remove dead code Heinrich Schuchardt <xypron.glpk@gmx.de> - 2016-08-21 20:10 +0200
  Re: [PATCH 1/1] drm/amdgpu/gmc7: remove dead code Joe Perches <joe@perches.com> - 2016-08-21 20:30 +0200
    Re: [PATCH 1/1] drm/amdgpu/gmc7: remove dead code Heinrich Schuchardt <xypron.glpk@gmx.de> - 2016-08-21 20:50 +0200
      Re: [PATCH 1/1] drm/amdgpu/gmc7: remove dead code Joe Perches <joe@perches.com> - 2016-08-21 21:00 +0200
  Re: [PATCH 1/1] drm/amdgpu/gmc7: remove dead code Christian König <deathsimple@vodafone.de> - 2016-08-22 09:50 +0200

csiph-web