Re: [PATCH v3] block: make sure big bio is splitted into at most 256 bvecs

From	Kent Overstreet <kent.overstreet@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] block: make sure big bio is splitted into at most 256 bvecs
Date	2016-08-21 20:00 +0200
Message-ID	<s8Fcl-3qf-5@gated-at.bofh.it> (permalink)
References	<s6rQe-7ef-29@gated-at.bofh.it> <s6uO5-C5-1@gated-at.bofh.it> <s6vAu-18k-43@gated-at.bofh.it> <s7Gat-6Ui-13@gated-at.bofh.it> <s8xot-6ZZ-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Aug 21, 2016 at 05:31:33PM +0800, Ming Lei wrote:
> This patch is definitely correct, and I don't see dealing with 'no_merge'
> should be removed.
> 
> In this case, the bio is still possible to merge with others because
> it doesn't violate any limit of the queue because it just can't be held in
> 256 bvecs, that means it is correct to clear no_merge for this situation.
> 
> Also I don't think it is complicated or ugly to deal with the flag.

It's extra unnecessary code. All other things being equal, less code is always
better than more code. It works just fine without it, what's the justification
for adding the flag?

Don't be so dismissive of other maintainer's concerns, we've got to deal with
this code too. Especially when I and Christoph are agreeing on something - how
often does that happen?

Thread

[PATCH v3] block: make sure big bio is splitted into at most 256 bvecs Ming Lei <ming.lei@canonical.com> - 2016-08-15 17:20 +0200
  Re: [PATCH v3] block: make sure big bio is splitted into at most 256  bvecs Christoph Hellwig <hch@infradead.org> - 2016-08-15 20:30 +0200
    Re: [PATCH v3] block: make sure big bio is splitted into at most 256  bvecs Kent Overstreet <kent.overstreet@gmail.com> - 2016-08-15 21:20 +0200
      Re: [PATCH v3] block: make sure big bio is splitted into at most  256 bvecs Eric Wheeler <bcache@lists.ewheeler.net> - 2016-08-19 02:50 +0200
        Re: [PATCH v3] block: make sure big bio is splitted into at most 256 bvecs Ming Lei <ming.lei@canonical.com> - 2016-08-21 11:40 +0200
          Re: [PATCH v3] block: make sure big bio is splitted into at most 256  bvecs Kent Overstreet <kent.overstreet@gmail.com> - 2016-08-21 20:00 +0200
            Re: [PATCH v3] block: make sure big bio is splitted into at most 256 bvecs Ming Lei <ming.lei@canonical.com> - 2016-08-22 11:00 +0200

csiph-web