Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1466993

Re: [PATCH] iio: chemical: atlas-ph-sensor: fix typo in val assignment

Show all headers | View raw

On 27/07/16 10:28, Matt Ranostay wrote:
> On Mon, Jul 25, 2016 at 3:06 PM, Colin King <colin.king@canonical.com> wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> Fix an incorrect assignment due to a typo on a variable name. The
>> variable val2 should be assigned 100000 and not val.
> 
> Yikes! Good catch..
> 
> Reviewed-By: Matt Ranostay <mranostay@gmail.com>
> 
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks Colin.

Applied to the fixes-togreg branch of iio.git. Should head upstream
in a day or two.

Jonathan
>> ---
>>  drivers/iio/chemical/atlas-ph-sensor.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/chemical/atlas-ph-sensor.c b/drivers/iio/chemical/atlas-ph-sensor.c
>> index ae038a5..407f141 100644
>> --- a/drivers/iio/chemical/atlas-ph-sensor.c
>> +++ b/drivers/iio/chemical/atlas-ph-sensor.c
>> @@ -434,7 +434,7 @@ static int atlas_read_raw(struct iio_dev *indio_dev,
>>                         break;
>>                 case IIO_ELECTRICALCONDUCTIVITY:
>>                         *val = 1; /* 0.00001 */
>> -                       *val = 100000;
>> +                       *val2 = 100000;
>>                         break;
>>                 case IIO_CONCENTRATION:
>>                         *val = 0; /* 0.000000001 */
>> --
>> 2.8.1
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] iio: chemical: atlas-ph-sensor: fix typo in val  assignment Jonathan Cameron <jic23@kernel.org> - 2016-08-21 17:20 +0200

csiph-web