Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1466981
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 4/7] USB-iowarrior: Delete unnecessary initialisations in iowarrior_open() |
| Date | 2016-08-21 16:10 +0200 |
| Message-ID | <s8BBL-1lk-1@gated-at.bofh.it> (permalink) |
| References | <qEuGl-43C-5@gated-at.bofh.it> <s8Bs5-12P-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 21 Aug 2016 15:15:03 +0200
Two local variables will be set to an appropriate value a bit later.
Thus omit the explicit initialisation at the beginning.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/usb/misc/iowarrior.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/misc/iowarrior.c b/drivers/usb/misc/iowarrior.c
index 449bf64..e3564d8 100644
--- a/drivers/usb/misc/iowarrior.c
+++ b/drivers/usb/misc/iowarrior.c
@@ -587,10 +587,10 @@ error_out:
*/
static int iowarrior_open(struct inode *inode, struct file *file)
{
- struct iowarrior *dev = NULL;
+ struct iowarrior *dev;
struct usb_interface *interface;
int subminor;
- int retval = 0;
+ int retval;
mutex_lock(&iowarrior_mutex);
subminor = iminor(inode);
--
2.9.3
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/7] USB-iowarrior: Fine-tuning for some function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-21 16:00 +0200 [PATCH 3/7] USB-iowarrior: Delete an unnecessary initialisation in iowarrior_release() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-21 16:00 +0200 [PATCH 4/7] USB-iowarrior: Delete unnecessary initialisations in iowarrior_open() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-21 16:10 +0200 [PATCH 6/7] USB-iowarrior: Delete unnecessary braces SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-21 16:10 +0200 [PATCH 7/7] USB-iowarrior: Apply another recommendation from "checkpatch.pl" SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-21 16:10 +0200 [PATCH 5/7] USB-iowarrior: Delete unnecessary initialisations in iowarrior_write() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-21 16:10 +0200
csiph-web