Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1465372

Re: [PATCH v3 0/5] bug: Provide toggle for BUG on data corruption

Show all headers | View raw

On Wed, 17 Aug 2016 14:42:07 -0700
Kees Cook <keescook@chromium.org> wrote:

> This adds CONFIG_BUG_ON_DATA_CORRUPTION to trigger BUG()s when the kernel
> encounters unexpected data structure integrity as currently detected
> with CONFIG_DEBUG_LIST.
> 
> Specifically list operations have been a target for widening flaws to gain
> "write anywhere" primitives for attackers, so this also consolidates the
> debug checking to avoid code and check duplication (e.g. RCU list debug
> was missing a check that got added to regular list debug). It also stops
> manipulations when corruption is detected, since worsening the corruption
> makes no sense. (Really, everyone should build with CONFIG_DEBUG_LIST
> since the checks are so inexpensive.)
> 
> This is mostly a refactoring of similar code from PaX and Grsecurity,
> along with MSM kernel changes by Syed Rameez Mustafa.
> 
> Along with the patches is a new lkdtm test to validate that setting
> CONFIG_DEBUG_LIST actually does what is desired.
> 

The series looks fine by me.

Acked-by: Steven Rostedt <rostedt@goodmis.org>

-- Steve

> Thanks,
> 
> -Kees
> 
> v3:
> - fix MSM attribution, sboyd
> - use pr_err, joe
> 
> v2:
> - consolidate printk/WARN/BUG/return logic into a CONFIG-specific macro
> - drop non-list BUGs, labbott

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/5] bug: Provide toggle for BUG on data corruption Kees Cook <keescook@chromium.org> - 2016-08-17 23:50 +0200
  [PATCH v3 4/5] bug: Provide toggle for BUG on data corruption Kees Cook <keescook@chromium.org> - 2016-08-17 23:50 +0200
    Re: [PATCH v3 4/5] bug: Provide toggle for BUG on data corruption Arnd Bergmann <arnd@arndb.de> - 2016-08-22 15:20 +0200
      Re: [PATCH v3 4/5] bug: Provide toggle for BUG on data corruption "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-08-22 20:00 +0200
        Re: [kernel-hardening] Re: [PATCH v3 4/5] bug: Provide toggle for BUG  on data corruption Kees Cook <keescook@chromium.org> - 2016-08-23 00:40 +0200
  Re: [PATCH v3 0/5] bug: Provide toggle for BUG on data corruption Steven Rostedt <rostedt@goodmis.org> - 2016-08-18 15:50 +0200
    Re: [PATCH v3 0/5] bug: Provide toggle for BUG on data corruption "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-08-19 03:10 +0200
  Re: [kernel-hardening] [PATCH v3 0/5] bug: Provide toggle for BUG  on data corruption Rik van Riel <riel@redhat.com> - 2016-08-19 03:00 +0200
    Re: [kernel-hardening] [PATCH v3 0/5] bug: Provide toggle for BUG on  data corruption "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-08-19 03:30 +0200
      Re: [kernel-hardening] [PATCH v3 0/5] bug: Provide toggle for BUG  on data corruption Rik van Riel <riel@redhat.com> - 2016-08-19 05:00 +0200
        Re: [kernel-hardening] [PATCH v3 0/5] bug: Provide toggle for BUG on  data corruption "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-08-19 19:50 +0200

csiph-web