Re: [PATCH 1/1] rbtree: correct mask for extracting node's parent

From	zijun_hu <zijun_hu@zoho.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1] rbtree: correct mask for extracting node's parent
Date	2016-08-18 14:20 +0200
Message-ID	<s7usF-86E-11@gated-at.bofh.it> (permalink)
References	<s7qIp-5vQ-3@gated-at.bofh.it> <s7rOa-6fy-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 08/18/2016 05:01 PM, Peter Zijlstra wrote:
> On Thu, Aug 18, 2016 at 04:19:10PM +0800, zijun_hu wrote:
>> From: zijun_hu <zijun_hu@htc.com>
>>
>> for LP64 ABI, struct rb_node aligns at 8 bytes boundary due to
>> sizeof(long) == 8 normally, so 0x07 should be used to extract
>> node's parent rather than 0x03
> 
> Doesn't matter though, in practise. The remaining bits are always 0.
> 
okay, understand
it maybe more readable to replace hard coding numbers by macros

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] rbtree: correct mask for extracting node's parent zijun_hu <zijun_hu@zoho.com> - 2016-08-18 10:20 +0200
  Re: [PATCH 1/1] rbtree: correct mask for extracting node's parent Peter Zijlstra <peterz@infradead.org> - 2016-08-18 11:30 +0200
    Re: [PATCH 1/1] rbtree: correct mask for extracting node's parent zijun_hu <zijun_hu@zoho.com> - 2016-08-18 14:20 +0200

csiph-web