Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1465054

Re: [PATCH 1/2] x86/smpboot: Check APIC ID before setting up default routing

Show all headers | View raw

* Wei Jiangang <weijg.fnst@cn.fujitsu.com> wrote:

> Check the boot APIC ID firstly,
> and then setup the default routing of APIC looks better.
> 
> And move default_setup_apic_routing() close to apic_bsp_setup(),
> which staying in step with the codes in APIC_init_uniprocessor().
> 
> Signed-off-by: Wei Jiangang <weijg.fnst@cn.fujitsu.com>
> ---
>  arch/x86/kernel/smpboot.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

If it's not a bug then please clearly note so in the changelog and
explain why the change results in better code.

If it's fixing a bug/misfeature then please fix the changelog to
conform to the standard changelog style:

 - first describe the symptoms of the bug - how does a user notice? 

 - then describe how the code behaves today and how that is causing the bug

 - and then only describe how it's fixed.

Thanks,

        Ingo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] x86/smpboot: Check APIC ID before setting up default routing Wei Jiangang <weijg.fnst@cn.fujitsu.com> - 2016-08-17 08:50 +0200
  Re: [PATCH 1/2] x86/smpboot: Check APIC ID before setting up default  routing Ingo Molnar <mingo@kernel.org> - 2016-08-18 11:50 +0200
    Re: [PATCH 1/2] x86/smpboot: Check APIC ID before setting up  default routing "Wei, Jiangang" <weijg.fnst@cn.fujitsu.com> - 2016-08-18 12:20 +0200

csiph-web