Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1464942

Re: [PATCH v2 2/2] fs: super.c: Add tracepoint to get name of superblock shrinker

Show all headers | View raw

On Thu 18-08-16 07:32:39, Al Viro wrote:
> On Thu, Aug 18, 2016 at 02:09:31AM -0400, Janani Ravichandran wrote:
> 
> >  static LIST_HEAD(super_blocks);
> > @@ -64,6 +65,7 @@ static unsigned long super_cache_scan(struct shrinker *shrink,
> >  	long	inodes;
> >  
> >  	sb = container_of(shrink, struct super_block, s_shrink);
> > +	trace_mm_shrinker_callback(shrink, sb->s_type->name);
> 
> IOW, we are (should that patch be accepted) obliged to keep the function in
> question and the guts of struct shrinker indefinitely.

I am not aware that trace points are considered a stable ABI. Is that
documented anywhere? We have changed/removed some of them in the
past. If there is a debugging tool parsing them the tool itself is
responsible to keep track of any changes.
-- 
Michal Hocko
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/2] Get callbacks/names of shrinkers from tracepoints Janani Ravichandran <janani.rvchndrn@gmail.com> - 2016-08-18 07:40 +0200
  [PATCH v2 1/2] include: trace: Display names of shrinker callbacks Janani Ravichandran <janani.rvchndrn@gmail.com> - 2016-08-18 07:50 +0200
  [PATCH v2 2/2] fs: super.c: Add tracepoint to get name of superblock  shrinker Janani Ravichandran <janani.rvchndrn@gmail.com> - 2016-08-18 08:20 +0200
    Re: [PATCH v2 2/2] fs: super.c: Add tracepoint to get name of  superblock shrinker Al Viro <viro@ZenIV.linux.org.uk> - 2016-08-18 08:40 +0200
      Re: [PATCH v2 2/2] fs: super.c: Add tracepoint to get name of  superblock shrinker Michal Hocko <mhocko@kernel.org> - 2016-08-18 08:50 +0200
      Re: [PATCH v2 2/2] fs: super.c: Add tracepoint to get name of  superblock shrinker Rik van Riel <riel@surriel.com> - 2016-08-18 15:30 +0200

csiph-web