[PATCH] drm/rockchip: analogix_dp: drop unnecessary probe deferral "error" print

From	Brian Norris <briannorris@chromium.org>
Newsgroups	linux.kernel
Subject	[PATCH] drm/rockchip: analogix_dp: drop unnecessary probe deferral "error" print
Date	2016-08-17 23:20 +0200
Message-ID	<s7gpH-6MJ-7@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

This driver is the only user of of_drm_find_panel() which prints an
error before doing probe deferral, yielding messages like this on boot,
before eventually succeeding:

[    2.234271] [drm:rockchip_dp_probe] *ERROR* failed to find panel
...
[    4.797539] [drm:rockchip_dp_probe] *ERROR* failed to find panel
...

Let's just drop the message.

Signed-off-by: Brian Norris <briannorris@chromium.org>
---
 drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
index 89aadbf465f8..045fcc46827c 100644
--- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
+++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
@@ -381,10 +381,8 @@ static int rockchip_dp_probe(struct platform_device *pdev)
 
 		panel = of_drm_find_panel(panel_node);
 		of_node_put(panel_node);
-		if (!panel) {
-			DRM_ERROR("failed to find panel\n");
+		if (!panel)
 			return -EPROBE_DEFER;
-		}
 	}
 
 	dp = devm_kzalloc(dev, sizeof(*dp), GFP_KERNEL);
-- 
2.8.0.rc3.226.g39d4020

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] drm/rockchip: analogix_dp: drop unnecessary probe deferral "error" print Brian Norris <briannorris@chromium.org> - 2016-08-17 23:20 +0200
  Re: [PATCH] drm/rockchip: analogix_dp: drop unnecessary probe  deferral "error" print Sean Paul <seanpaul@chromium.org> - 2016-08-17 23:30 +0200

csiph-web