Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1464700
| From | Ross Zwisler <ross.zwisler@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] ext4: allow DAX writeback for hole punch |
| Date | 2016-08-17 20:20 +0200 |
| Message-ID | <s7dBv-4DV-7@gated-at.bofh.it> (permalink) |
| References | <s7bJo-3pe-17@gated-at.bofh.it> <s7cP7-469-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, Aug 17, 2016 at 07:19:55PM +0200, Jan Kara wrote: > On Wed 17-08-16 10:11:02, Ross Zwisler wrote: > > Currently when doing a DAX hole punch with ext4 we fail to do a writeback. > > This is because the logic around filemap_write_and_wait_range() in > > ext4_punch_hole() only looks for dirty page cache pages in the radix tree, > > not for dirty DAX exceptional entries. > > > > Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com> > > Thanks. The patch looks correct, you can add: > > Reviewed-by: Jan Kara <jack@suse.cz> > > Although why don't we just simplify the test below to > mapping_tagged(mapping, PAGECACHE_TAG_DIRTY)? After all the mapping should > not have the dirty tag set if there are no pages / no entries? Sure, that works. I'll update to that in V2, and I'll add stable. Thanks!
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] ext4: allow DAX writeback for hole punch Ross Zwisler <ross.zwisler@linux.intel.com> - 2016-08-17 18:20 +0200
Re: [PATCH] ext4: allow DAX writeback for hole punch Jan Kara <jack@suse.cz> - 2016-08-17 19:30 +0200
Re: [PATCH] ext4: allow DAX writeback for hole punch Ross Zwisler <ross.zwisler@linux.intel.com> - 2016-08-17 20:20 +0200
[PATCH v2] ext4: allow DAX writeback for hole punch Ross Zwisler <ross.zwisler@linux.intel.com> - 2016-08-17 20:30 +0200
csiph-web