Re: [PATCH] dmaengine: qcom_hidma: release the descriptor before the callback

From	Sinan Kaya <okaya@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] dmaengine: qcom_hidma: release the descriptor before the callback
Date	2016-08-19 19:40 +0200
Message-ID	<s7VVT-7y-13@gated-at.bofh.it> (permalink)
References	(6 earlier) <s7IP0-hA-15@gated-at.bofh.it> <s7IYF-kP-5@gated-at.bofh.it> <s7KQN-1xs-5@gated-at.bofh.it> <s7Q9P-4Yv-3@gated-at.bofh.it> <s7Vjc-85Q-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 8/19/2016 1:02 PM, Vinod Koul wrote:
> On Fri, Aug 19, 2016 at 07:13:43AM -0400, okaya@codeaurora.org wrote:
>> On 2016-08-19 01:52, Vinod Koul wrote:
>>> On Thu, Aug 18, 2016 at 11:48:52PM -0400, Sinan Kaya wrote:
>>>> On 8/18/2016 11:42 PM, Vinod Koul wrote:
>>>>> On Thu, Aug 18, 2016 at 11:26:28PM -0400, Sinan Kaya wrote:
>>>>>> On 8/18/2016 10:48 PM, Vinod Koul wrote:
>>>>>>>> Keep a size limited list with error cookies and flush them in terminate all?
>>>>>>> I think so, terminate_all anyway cleans up the channel. Btw what is the
>>>>>>> behaviour on error? Do you terminate or somthing else?
>>>>>>>
>>>>>>
>>>>>> On error, I flush all outstanding transactions with an error code and I reset
>>>>>> the channel. After the reset, the DMA channel is functional again. The client
>>>>>> doesn't need to shutdown anything.
>>>>>
>>>>> You mean from the client context or driver?
>>>>>
>>>>
>>>> The client doesn't need to call device_free_chan_resources and
>>>> device_terminate_all
>>>> to be specific. Client can certainly call these if it needs to
>>>> but it is not
>>>> required to recover the channel.
>>>
>>> You didn't answer my question!
>>>
>>> On error you said you flush, so who does that?
>>
>> This is done by the driver in interrupt context when an error
>> interrupt is received. All transactions are posted and hw is reset.
> 
> Hmmm, waht about the txn which are pending? DO you clear them..?
> 

Yes, I clear both pending and active transactions. 

-- 
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.

Thread

Re: [PATCH] dmaengine: qcom_hidma: release the descriptor before the  callback Vinod Koul <vinod.koul@intel.com> - 2016-08-19 04:50 +0200
  Re: [PATCH] dmaengine: qcom_hidma: release the descriptor before the  callback Sinan Kaya <okaya@codeaurora.org> - 2016-08-19 05:40 +0200
    Re: [PATCH] dmaengine: qcom_hidma: release the descriptor before the  callback Vinod Koul <vinod.koul@intel.com> - 2016-08-19 05:40 +0200
      Re: [PATCH] dmaengine: qcom_hidma: release the descriptor before the  callback Sinan Kaya <okaya@codeaurora.org> - 2016-08-19 05:50 +0200
        Re: [PATCH] dmaengine: qcom_hidma: release the descriptor before the  callback Vinod Koul <vinod.koul@intel.com> - 2016-08-19 07:50 +0200
          Re: [PATCH] dmaengine: qcom_hidma: release the descriptor before the  callback okaya@codeaurora.org - 2016-08-19 13:30 +0200
            Re: [PATCH] dmaengine: qcom_hidma: release the descriptor before the  callback Vinod Koul <vinod.koul@intel.com> - 2016-08-19 19:00 +0200
              Re: [PATCH] dmaengine: qcom_hidma: release the descriptor before the  callback Sinan Kaya <okaya@codeaurora.org> - 2016-08-19 19:40 +0200
                Re: [PATCH] dmaengine: qcom_hidma: release the descriptor before the  callback Vinod Koul <vinod.koul@intel.com> - 2016-08-22 08:20 +0200
                Re: [PATCH] dmaengine: qcom_hidma: release the descriptor before the  callback Sinan Kaya <okaya@codeaurora.org> - 2016-08-22 15:30 +0200
                Re: [PATCH] dmaengine: qcom_hidma: release the descriptor before the  callback Vinod Koul <vinod.koul@intel.com> - 2016-08-22 19:00 +0200

csiph-web