Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1466495
| From | Marek Olšák <maraeo@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from <linux/types.h>" |
| Date | 2016-08-19 17:30 +0200 |
| Message-ID | <s7TU5-7ld-9@gated-at.bofh.it> (permalink) |
| References | <s7Tr4-6UW-21@gated-at.bofh.it> <s7Tr4-6UW-23@gated-at.bofh.it> <s7Tr4-6UW-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Aug 19, 2016 at 4:52 PM, Mikko Rapeli <mikko.rapeli@iki.fi> wrote: > On Fri, Aug 19, 2016 at 04:26:40PM +0200, Christian König wrote: >> Am 19.08.2016 um 15:50 schrieb Marek Olšák: >> >From: Marek Olšák <marek.olsak@amd.com> >> > >> >This reverts commit 2ce9dde0d47f2f94ab25c73a30596a7328bcdf1f. >> > >> >See the comment in the code. Basically, don't do cleanups in this header. >> > >> >Signed-off-by: Marek Olšák <marek.olsak@amd.com> >> >> I completely agree with you that this was a bad move, but I fear that we >> will run into opposition with that. >> >> Adding Mikko Rapeli who made the reverted patch to comment. > > But this header is part of Linux kernel uapi. Remove it from there too then. That's a good idea, but it really is a uapi header in the sense that it defines the kernel driver interface for a specific kernel version. However, it is not a header that the userspace stack should include, because userspace should get it from libdrm. (it makes userspace more independent from the currently running kernel) Marek
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from <linux/types.h>" Mikko Rapeli <mikko.rapeli@iki.fi> - 2016-08-19 17:00 +0200
Re: [PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from <linux/types.h>" Marek Olšák <maraeo@gmail.com> - 2016-08-19 17:30 +0200
Re: [PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from <linux/types.h>" Daniel Vetter <daniel@ffwll.ch> - 2016-08-19 19:20 +0200
Re: [PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from <linux/types.h>" Marek Olšák <maraeo@gmail.com> - 2016-08-19 19:30 +0200
Re: [PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from <linux/types.h>" Daniel Vetter <daniel@ffwll.ch> - 2016-08-19 19:20 +0200
csiph-web