Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1466460
| From | David Woodhouse <dwmw2@infradead.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v1 2/3] of: Add support for reading a s32 from a multi-value property. |
| Date | 2016-08-19 16:20 +0200 |
| Message-ID | <s7SOm-6FX-17@gated-at.bofh.it> (permalink) |
| References | <s6CBX-5G4-3@gated-at.bofh.it> <s6CLE-5JI-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Tue, 2016-08-16 at 10:38 +0800, Finlye Xiao wrote: > From: Finley Xiao <finley.xiao@rock-chips.com> > > This patch adds an of_property_read_s32_index() function to allow > reading a single indexed s32 value from a property containing multiple > s32 values. > > Signed-off-by: Finley Xiao <finley.xiao@rock-chips.com> NAK. Nobody should be using the old of_property_* functions any more anyway. You should be using the generic device_propery_* functions which work regardless of where the information comes from (actual DT vs. ACPI _DSD). So no, don't *add* any more of these functions. Only add the generic version. And if your driver isn't using the generic property functions... fix it. -- David Woodhouse Open Source Technology Centre David.Woodhouse@intel.com Intel Corporation
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v1 2/3] of: Add support for reading a s32 from a multi-value property. Finlye Xiao <finley.xiao@rock-chips.com> - 2016-08-16 05:00 +0200
Re: [PATCH v1 2/3] of: Add support for reading a s32 from a multi-value property. Heiko Stübner <heiko@sntech.de> - 2016-08-16 14:20 +0200
Re: [PATCH v1 2/3] of: Add support for reading a s32 from a multi-value property. David Woodhouse <dwmw2@infradead.org> - 2016-08-19 16:20 +0200
Re: [PATCH v1 2/3] of: Add support for reading a s32 from a multi-value property. Heiko Stuebner <heiko@sntech.de> - 2016-08-19 22:50 +0200
Re: [PATCH v1 2/3] of: Add support for reading a s32 from a multi-value property. David Woodhouse <dwmw2@infradead.org> - 2016-08-19 23:00 +0200
Re: [PATCH v1 2/3] of: Add support for reading a s32 from a multi-value property. Finley Xiao <finley.xiao@rock-chips.com> - 2016-08-22 16:10 +0200
Re: [PATCH v1 2/3] of: Add support for reading a s32 from a multi-value property. Mark Rutland <mark.rutland@arm.com> - 2016-08-22 17:00 +0200
csiph-web