Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1466387
| From | Andrew Lunn <andrew@lunn.ch> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/2] net: phy: Add error checks in the driver |
| Date | 2016-08-19 15:20 +0200 |
| Message-ID | <s7RSh-65h-9@gated-at.bofh.it> (permalink) |
| References | <s7RSh-65h-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
> - mdiobus_write(phydev->mdio.bus, priv->addr, XILINX_GMII2RGMII_REG, val); > + err = mdiobus_write(phydev->mdio.bus, priv->addr, XILINX_GMII2RGMII_REG, > + val); > + if (err < 0) > + return err; > > return 0; Do you need to assign err? Why not just return mdiobus_write(phydev->mdio.bus, priv->addr, XILINX_GMII2RGMII_REG, val);
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH 1/2] net: phy: Add error checks in the driver Andrew Lunn <andrew@lunn.ch> - 2016-08-19 15:20 +0200
csiph-web