Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1466327

[PATCH] mm: Add WARN_ON for possibility of infinite loop if empty lists in free_pcppages_bulk'

Show all headers | View raw

While debugging issue in realtime kernel i found a scenario
which resulted in infinite loop resulting because of empty pcp->lists
and valid 'to_free' value. This patch is to add 'WARN_ON' in function
'free_pcppages_bulk' if there is possibility of infinite loop because 
of any bug in code.

Signed-off-by: Pankaj Gupta <pagupta@redhat.com>
---
 mm/page_alloc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 3fbe73a..07d3080 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -1096,6 +1096,8 @@ static void free_pcppages_bulk(struct zone *zone, int count,
 			if (++migratetype == MIGRATE_PCPTYPES)
 				migratetype = 0;
 			list = &pcp->lists[migratetype];
+
+			WARN_ON(batch_free > MIGRATE_PCPTYPES);
 		} while (list_empty(list));
 
 		/* This is the only non-empty list. Free them all. */
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] mm: Add WARN_ON for possibility of infinite loop if empty lists in free_pcppages_bulk' Pankaj Gupta <pagupta@redhat.com> - 2016-08-19 14:20 +0200
  Re: [PATCH] mm: Add WARN_ON for possibility of infinite loop if  empty lists in free_pcppages_bulk' Mel Gorman <mgorman@techsingularity.net> - 2016-08-19 14:50 +0200
    Re: [PATCH] mm: Add WARN_ON for possibility of infinite loop if  empty lists in free_pcppages_bulk' Pankaj Gupta <pagupta@redhat.com> - 2016-08-19 15:10 +0200
      Re: [PATCH] mm: Add WARN_ON for possibility of infinite loop if  empty lists in free_pcppages_bulk' Mel Gorman <mgorman@techsingularity.net> - 2016-08-19 16:10 +0200
        Re: [PATCH] mm: Add WARN_ON for possibility of infinite loop if  empty lists in free_pcppages_bulk' Pankaj Gupta <pagupta@redhat.com> - 2016-08-23 10:50 +0200

csiph-web