Re: [PATCH 0/2] GPU-DRM-Savage: Fine-tuning for savage_bci_cmdbuf()

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Daniel Vetter <daniel@ffwll.ch>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/2] GPU-DRM-Savage: Fine-tuning for savage_bci_cmdbuf()
Date	Fri, 19 Aug 2016 09:50:01 +0200
Message-ID	<s7MIV-2K9-5@gated-at.bofh.it> (permalink)
References	<qEuGl-43C-5@gated-at.bofh.it> <s7Hzz-817-1@gated-at.bofh.it>
X-Original-To	SF Markus Elfring <elfring@users.sourceforge.net>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=TGtA3pJP1tSAkMmjUQiZzEfXJiiNzk5W7BLuVNt5Osg=; b=gBdjsqhobpdf79pq4AWcKUgI9hv3kNi5mSySLg7kSVHnGDMihdqqZe5fjzq4ymEIe4 RJHgA5UoIqVvwIIrMlZpEV4/feN224vdPUlKqj4HODC2ZPXi90u6GJq+oBSjrxqmfdz4 1o99VyDjMl/bdZ3E++jv9miku2a3QKpNr4OdU=
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=TGtA3pJP1tSAkMmjUQiZzEfXJiiNzk5W7BLuVNt5Osg=; b=ghLGcNnRi2Mo2MicNhvhEDwtt6r/nUoO6O9VhCy8yYrHaI1Fg3FMNRAhLzFOW1EXnK 60/0AYtoFAJq2yItm1Y7Eqmxg7FC9AcuS0/Gy8RefEUYpoU3kLIhmojtxU0uoL5Ms9lm ticx7iFm/PZcdhxcAOcCPvabahMbqdwblmbUKJlUu5wZ02GHAjkKWN3ZYcyTqi47z42N Ruqjl937BWszmb6mGLAYIm5B4ik/+SgdcS+tgjkcpO9Jecs3lM3SQ0gP/2+uhPmKY2Fr ULDzWE40hZnJMRFWYkqZF/ooUjefrkUsIrDGMVeisPgo7K7BUYEsFEWbSXD50y6mekLt 0znA==
X-Gm-Message-State	AEkoouswGjqNL5Mc9yOFry2hrigwTVzp1g/eT7kmeO/HpUfLeQh/dxJVGMXNZ/9aUOUyow==
X-Received	by 10.28.99.86 with SMTP id x83mr2738087wmb.95.1471592502828; Fri, 19 Aug 2016 00:41:42 -0700 (PDT)
Mail-Followup-To	SF Markus Elfring <elfring@users.sourceforge.net>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, David Airlie <airlied@linux.ie>, LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org, Julia Lawall <julia.lawall@lip6.fr>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
X-Operating-System	Linux phenom 4.6.0-1-amd64
User-Agent	Mutt/1.6.0 (2016-04-01)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	29
Organization	linux.* mail to news gateway
X-Original-Cc	"dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>, LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org, Julia Lawall <julia.lawall@lip6.fr>
X-Original-Date	Fri, 19 Aug 2016 09:41:10 +0200
X-Original-Message-ID	<20160819074110.GT6232@phenom.ffwll.local>
X-Original-References	<566ABCD9.1060404@users.sourceforge.net> <77052ac1-1933-49af-3ad8-6e0eecc1aafe@users.sourceforge.net>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1466195

Show key headers only | View raw

On Thu, Aug 18, 2016 at 09:42:33PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 18 Aug 2016 21:38:37 +0200
> 
> A few update suggestions were taken into account
> from static source code analysis.

savage is one of the dri1 legacy drivers, imo not really worth it to spend
time on them. otoh no one will notice any breakage either ;-)

I guess I'll apply.
-Daniel

> 
> Markus Elfring (2):
>   Use memdup_user() rather than duplicating its implementation
>   Less function calls after error detection
> 
>  drivers/gpu/drm/savage/savage_state.c | 42 +++++++++++++++--------------------
>  1 file changed, 18 insertions(+), 24 deletions(-)
> 
> -- 
> 2.9.3
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] GPU-DRM-Savage: Fine-tuning for savage_bci_cmdbuf() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-19 04:20 +0200
  [PATCH 2/2] GPU-DRM-Savage: Less function calls in  savage_bci_cmdbuf() after error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-19 04:30 +0200
    Re: [PATCH 2/2] GPU-DRM-Savage: Less function calls in  savage_bci_cmdbuf() after error detection Daniel Vetter <daniel@ffwll.ch> - 2016-08-19 10:00 +0200
  [PATCH 1/2] GPU-DRM-Savage: Use memdup_user() rather than duplicating SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-19 05:00 +0200
  Re: [PATCH 0/2] GPU-DRM-Savage: Fine-tuning for savage_bci_cmdbuf() Daniel Vetter <daniel@ffwll.ch> - 2016-08-19 09:50 +0200

csiph-web