Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1466049

Use of copy_to_user in fireworks_hwdep.c while holding a spin_lock

Show all headers | View raw

Hello,

I was wondering about the call to copy_to_user in function hwdep_read_locked and
hwdep_read_resp_buf for driver sound/firewire/fireworks/fireworks_hwdep.c. 
The function hwdep_read calls both of these functions while holding a spinlock[1],
which is not normally allowed due to the possibility of a deadlock.

This seems to be coming from the commit 555e8a8f7f149544eb7d4aa3a6420bc4c3055638
while adding a command/response functionality into hwdep interface. Is there some
reason that I am overlooking, why it is OK in this case? Is there some code in the
same file which ensures that page fault will not occur when we are calling these
functions while holding a spin_lock_irq?

The same issue is there with the driver sound/firewire/tascam/tascam-hwdep.c for
obvious reasons.

Coccinelle script is used to detect this issue.

Thank you.

[1] http://lxr.free-electrons.com/source/sound/firewire/fireworks/fireworks_hwdep.c#L114

-- 
Vaishali

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Use of copy_to_user in fireworks_hwdep.c while holding a spin_lock Vaishali Thakkar <vaishali.thakkar@oracle.com> - 2016-08-19 08:30 +0200
  Re: Use of copy_to_user in fireworks_hwdep.c while holding a  spin_lock Takashi Sakamoto <o-takashi@sakamocchi.jp> - 2016-08-19 15:30 +0200

csiph-web