Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1465982

Re: [PATCH] fib_trie: Fix the description of pos and bits

Show all headers | View raw

On Wed, Aug 17, 2016 at 9:33 PM, Xunlei Pang <xlpang@redhat.com> wrote:
> 1) Fix one typo: s/tn/tp/
> 2) Fix the description about the "u" bits.
>
> Signed-off-by: Xunlei Pang <xlpang@redhat.com>
> ---
>  net/ipv4/fib_trie.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/ipv4/fib_trie.c b/net/ipv4/fib_trie.c
> index d07fc07..eb7c5d1 100644
> --- a/net/ipv4/fib_trie.c
> +++ b/net/ipv4/fib_trie.c
> @@ -249,7 +249,7 @@ static inline unsigned long get_index(t_key key, struct key_vector *kv)
>   * index into the parent's child array. That is, they will be used to find
>   * 'n' among tp's children.
>   *
> - * The bits from (n->pos + n->bits) to (tn->pos - 1) - "S" - are skipped bits
> + * The bits from (n->pos + n->bits) to (tp->pos - 1) - "S" - are skipped bits
>   * for the node n.
>   *
>   * All the bits we have seen so far are significant to the node n. The rest
> @@ -258,7 +258,7 @@ static inline unsigned long get_index(t_key key, struct key_vector *kv)
>   * The bits from (n->pos) to (n->pos + n->bits - 1) - "C" - are the index into
>   * n's child array, and will of course be different for each child.
>   *
> - * The rest of the bits, from 0 to (n->pos + n->bits), are completely unknown
> + * The rest of the bits, from 0 to (n->pos -1) - "u" - are completely unknown
>   * at this point.
>   */
>

These comment fixes all look correct.

Acked-by: Alexander Duyck <alexander.h.duyck@intel.com>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] fib_trie: Fix the description of pos and bits Xunlei Pang <xlpang@redhat.com> - 2016-08-18 06:40 +0200
  Re: [PATCH] fib_trie: Fix the description of pos and bits Alexander Duyck <alexander.duyck@gmail.com> - 2016-08-19 06:30 +0200
  Re: [PATCH] fib_trie: Fix the description of pos and bits David Miller <davem@davemloft.net> - 2016-08-19 09:00 +0200

csiph-web