Re: [PATCH] MIPS: Loongson1B: Change the OSC clock name

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Stephen Boyd <sboyd@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] MIPS: Loongson1B: Change the OSC clock name
Date	Fri, 19 Aug 2016 03:10:03 +0200
Message-ID	<s7GtR-7go-87@gated-at.bofh.it> (permalink)
References	<s5ilY-yH-9@gated-at.bofh.it> <s6zuq-3Hz-21@gated-at.bofh.it> <s7GtR-7go-89@gated-at.bofh.it>
X-Original-To	Kelvin Cheung <keguang.zhang@gmail.com>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	32
Organization	linux.* mail to news gateway
X-Original-Cc	linux-mips@linux-mips.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>
X-Original-Date	Thu, 18 Aug 2016 16:48:12 -0700
X-Original-Message-ID	<20160818234812.GI361@codeaurora.org>
X-Original-References	<1470999363-9978-1-git-send-email-keguang.zhang@gmail.com> <20160815232825.GW361@codeaurora.org> <CAJhJPsXs9nyR=ZJoMKFvOxR16jZ2n_F8DFmx0A=6Z5T_YxG3ag@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1465728

Show key headers only | View raw

On 08/16, Kelvin Cheung wrote:
> Hi Stephen,
> 
> 2016-08-16 7:28 GMT+08:00 Stephen Boyd <sboyd@codeaurora.org>:
> 
> > On 08/12, Keguang Zhang wrote:
> > > From: Kelvin Cheung <keguang.zhang@gmail.com>
> > >
> > > This patch changes the OSC clock name to "osc_clk".
> > >
> > > Signed-off-by: Kelvin Cheung <keguang.zhang@gmail.com>
> > > ---
> >
> > Yes, but why?
> >
> >
> Loongson1C uses a 24MHz oscillator, hence "osc_clk" sounds more appropriate
> 
> 

So then should we replace all the osc_33m_clk names with osc_clk?
This patch only modifies one name and it looks like a clkdev
lookup is created that still has osc_33m_clk for the connection
name in drivers/clk/clk-ls1x.c, so merging it would mean things
break? I also wonder what the pin is actually called in the
datasheet, because that should be what the cpufreq driver uses in
clk_get() as the connection id. If that's osc_33m_clk then it's
better to leave it alone even if the frequency is different.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] MIPS: Loongson1B: Change the OSC clock name Keguang Zhang <keguang.zhang@gmail.com> - 2016-08-12 13:00 +0200
  Re: [PATCH] MIPS: Loongson1B: Change the OSC clock name Stephen Boyd <sboyd@codeaurora.org> - 2016-08-16 01:30 +0200
    Re: [PATCH] MIPS: Loongson1B: Change the OSC clock name Stephen Boyd <sboyd@codeaurora.org> - 2016-08-19 03:10 +0200

csiph-web