Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1465844

Re: [PATCH RFC 1/3] hwspinlock: sun8i: add Allwinner sun8i HardWare Spinlock

Show all headers | View raw

Hello

Thanks for your review, I will fix all your reports for next version.

On 12/08/2016 21:06, Bjorn Andersson wrote:
> On Fri 12 Aug 04:46 PDT 2016, LABBE Corentin wrote:
> 
>> Add hwspinlock support for the Allwinner Hardware Spinlock device
>> present on the A83T, H3 and A64 SoCs.
>>
>> This Hardware Spinlock device provides hardware assistance
>> for synchronization between the multiple processors in the system.
>>
> [..]
>> +		goto clk_fail;
>> +	}
>> +
>> +	dev_info(&pdev->dev, "Sun8i hwspinlock driver loaded with %d locks\n",
>> +		 priv->num_locks);
> 
> Please don't advertise the driver on success.
> 

I was doing that because datasheet specify only 32 slot, but later a register give a possibility of more slots.
Perhaps its better to advertise only for uncommon hardware (slot > 32) ?

Regards

LABBE Corentin

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH RFC 1/3] hwspinlock: sun8i: add Allwinner sun8i HardWare Spinlock LABBE Corentin <clabbe.montjoie@gmail.com> - 2016-08-12 13:50 +0200
  Re: [PATCH RFC 1/3] hwspinlock: sun8i: add Allwinner sun8i HardWare  Spinlock Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-08-12 21:10 +0200
    Re: [PATCH RFC 1/3] hwspinlock: sun8i: add Allwinner sun8i HardWare  Spinlock Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-08-19 03:40 +0200
    Re: [PATCH RFC 1/3] hwspinlock: sun8i: add Allwinner sun8i HardWare  Spinlock Corentin LABBE <clabbe.montjoie@gmail.com> - 2016-08-19 03:50 +0200

csiph-web