Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1464587

[tip:timers/urgent] clocksource/drivers/time-armada-370-xp: Fix the clock reference

Show all headers | View raw

Commit-ID:  0e62fd836e4c2908cc1e32c68806529b4f859955
Gitweb:     http://git.kernel.org/tip/0e62fd836e4c2908cc1e32c68806529b4f859955
Author:     Gregory CLEMENT <gregory.clement@free-electrons.com>
AuthorDate: Wed, 17 Aug 2016 12:21:33 +0200
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 17 Aug 2016 13:08:31 +0200

clocksource/drivers/time-armada-370-xp: Fix the clock reference

While converting the init function to return an error, the wrong clock
was get. This leads to the wrong clock rate and slows down the kernel.
For example, it affects typical boot time:

 - without fix: over 1 minute
 - with    fix: 15 seconds

Tested-by: Stefan Roese <sr@denx.de>
Tested-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Fixes: 12549e27c63c ("clocksource/drivers/time-armada-370-xp: Convert init function to return error")
Link: http://lkml.kernel.org/r/1471429296-9053-1-git-send-email-daniel.lezcano@linaro.org
[ Refined the changelog. ]
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 drivers/clocksource/time-armada-370-xp.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/clocksource/time-armada-370-xp.c b/drivers/clocksource/time-armada-370-xp.c
index 719b478..3c39e6f 100644
--- a/drivers/clocksource/time-armada-370-xp.c
+++ b/drivers/clocksource/time-armada-370-xp.c
@@ -338,7 +338,6 @@ static int __init armada_xp_timer_init(struct device_node *np)
 	struct clk *clk = of_clk_get_by_name(np, "fixed");
 	int ret;
 
-	clk = of_clk_get(np, 0);
 	if (IS_ERR(clk)) {
 		pr_err("Failed to get clock");
 		return PTR_ERR(clk);

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PULL] : clockevents/clocksource fixes for 4.8 Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-08-17 12:20 +0200
  [PATCH 2/3] clocksource/drivers/kona: Fix get_counter error handling Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-08-17 12:30 +0200
    [tip:timers/urgent] clocksource/drivers/kona: Fix get_counter()  error handling tip-bot for Arnd Bergmann <tipbot@zytor.com> - 2016-08-17 15:40 +0200
  [PATCH 3/3] clocksource/drivers/mips-gic-timer: Make gic_clocksource_of_init return int Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-08-17 12:30 +0200
    [tip:timers/urgent] clocksource/drivers/mips-gic-timer: Make  gic_clocksource_of_init() return int tip-bot for Paul Gortmaker <tipbot@zytor.com> - 2016-08-17 15:40 +0200
  [PATCH 1/3] clocksource/drivers/time-armada-370-xp: Fix the clock reference Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-08-17 12:30 +0200
    [tip:timers/urgent] clocksource/drivers/time-armada-370-xp: Fix the  clock reference tip-bot for Gregory CLEMENT <tipbot@zytor.com> - 2016-08-17 15:40 +0200

csiph-web