Re: [PATCH v2 1/2] devicetree: Add vendor prefix for Shenzhen Sunchip Technology Co., Ltd

From	Rob Herring <robh@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/2] devicetree: Add vendor prefix for Shenzhen Sunchip Technology Co., Ltd
Date	2016-08-17 15:00 +0200
Message-ID	<s78BQ-19e-9@gated-at.bofh.it> (permalink)
References	<s5uwN-ac-9@gated-at.bofh.it> <s5ZqW-5AD-17@gated-at.bofh.it> <s6M8h-3cC-19@gated-at.bofh.it> <s6Rrk-6BB-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Aug 16, 2016 at 1:28 PM, Rask Ingemann Lambertsen
<ccc94453@vip.cybercity.dk> wrote:
> On Tue, Aug 16, 2016 at 07:56:24AM -0500, Rob Herring wrote:
>> On Thu, Aug 11, 2016 at 10:11:51PM +0200, Rask Ingemann Lambertsen wrote:
>> >
>> > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
>> > index 1992aa9..fbad2cea 100644
>> > --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
>> > +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
>> > @@ -256,6 +256,7 @@ ste     ST-Ericsson
>> >  stericsson ST-Ericsson
>> >  syna       Synaptics Inc.
>> >  synology   Synology, Inc.
>> > +sunchip    Shenzhen Sunchip Technology Co., Ltd
>> >  SUNW       Sun Microsystems, Inc
>>
>> These are not in alphabetical order. Maybe someone thought uppercase
>> should be separate, but I don't. So please fix the ordering here moving
>> SUNW before syna.
>
> I'm new to this, so I could use a bit of guidance here. Is it OK if I
> send a follow-up patch to fix the ordering or should I send a patch to
> fix the ordering first, before the sunchip prefix is added?

For this, just doing it all in one patch is fine. If you want to do 2
patches, then fix SUNW first then add sunchip.

> I never considered the possibility that the list wouldn't be in
> alphabetical order to begin with, so the brain power went into deciding
> if uppercase should be sorted separately.

Even if uppercase is sorted after lowercase, you've got it in the wrong place.

Rob

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] devicetree: Add vendor prefix for Shenzhen Sunchip  Technology Co., Ltd Rask Ingemann Lambertsen <ccc94453@vip.cybercity.dk> - 2016-08-13 02:10 +0200
  [PATCH v2 1/2] devicetree: Add vendor prefix for Shenzhen Sunchip  Technology Co., Ltd Rask Ingemann Lambertsen <ccc94453@vip.cybercity.dk> - 2016-08-14 11:00 +0200
    [PATCH v2 2/2] ARM: dts: sun9i: Initial support for the Sunchip  CX-A99 board Rask Ingemann Lambertsen <ccc94453@vip.cybercity.dk> - 2016-08-14 11:00 +0200
    Re: [PATCH v2 1/2] devicetree: Add vendor prefix for Shenzhen  Sunchip Technology Co., Ltd Rob Herring <robh@kernel.org> - 2016-08-16 15:00 +0200
      Re: [PATCH v2 1/2] devicetree: Add vendor prefix for Shenzhen  Sunchip Technology Co., Ltd Rask Ingemann Lambertsen <ccc94453@vip.cybercity.dk> - 2016-08-16 20:40 +0200
        Re: [PATCH v2 1/2] devicetree: Add vendor prefix for Shenzhen Sunchip  Technology Co., Ltd Rob Herring <robh@kernel.org> - 2016-08-17 15:00 +0200

csiph-web