[PATCH 1/2] drivers/clocksource/pistachio: fix memory corruption in init

From	Marcin Nowakowski <marcin.nowakowski@imgtec.com>
Newsgroups	linux.kernel
Subject	[PATCH 1/2] drivers/clocksource/pistachio: fix memory corruption in init
Date	2016-08-17 12:30 +0200
Message-ID	<s76gF-8a1-9@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Driver init code incorrectly uses the block base address and as a result
clears clocksource structure's fields instead of the hardware registers.

Commit 09a998201649 ("timekeeping: Lift clocksource cacheline
restriction") has changed the offsets within pistachio_clocksource
structure and what has previously gone unnoticed now leads to a kernel
panic during boot.

Signed-off-by: Marcin Nowakowski <marcin.nowakowski@imgtec.com>
---
 drivers/clocksource/time-pistachio.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/clocksource/time-pistachio.c b/drivers/clocksource/time-pistachio.c
index a7d9a08..a8e6c7d 100644
--- a/drivers/clocksource/time-pistachio.c
+++ b/drivers/clocksource/time-pistachio.c
@@ -202,10 +202,10 @@ static int __init pistachio_clksrc_of_init(struct device_node *node)
 	rate = clk_get_rate(fast_clk);
 
 	/* Disable irq's for clocksource usage */
-	gpt_writel(&pcs_gpt.base, 0, TIMER_IRQ_MASK, 0);
-	gpt_writel(&pcs_gpt.base, 0, TIMER_IRQ_MASK, 1);
-	gpt_writel(&pcs_gpt.base, 0, TIMER_IRQ_MASK, 2);
-	gpt_writel(&pcs_gpt.base, 0, TIMER_IRQ_MASK, 3);
+	gpt_writel(pcs_gpt.base, 0, TIMER_IRQ_MASK, 0);
+	gpt_writel(pcs_gpt.base, 0, TIMER_IRQ_MASK, 1);
+	gpt_writel(pcs_gpt.base, 0, TIMER_IRQ_MASK, 2);
+	gpt_writel(pcs_gpt.base, 0, TIMER_IRQ_MASK, 3);
 
 	/* Enable timer block */
 	writel(TIMER_ME_GLOBAL, pcs_gpt.base);
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] drivers/clocksource/pistachio: fix memory corruption in init Marcin Nowakowski <marcin.nowakowski@imgtec.com> - 2016-08-17 12:30 +0200
  [PATCH 2/2] drivers/clocksource/pistachio: improve register offset calculation Marcin Nowakowski <marcin.nowakowski@imgtec.com> - 2016-08-17 12:30 +0200
  Re: [PATCH 1/2] drivers/clocksource/pistachio: fix memory corruption  in init Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-08-23 17:40 +0200

csiph-web