[PATCH v4 3/5] x86/ioapic: Fix setup_res() failing to get resource

From	Rui Wang <rui.y.wang@intel.com>
Newsgroups	linux.kernel
Subject	[PATCH v4 3/5] x86/ioapic: Fix setup_res() failing to get resource
Date	2016-08-17 10:20 +0200
Message-ID	<s74eR-6Pr-19@gated-at.bofh.it> (permalink)
References	<s74eR-6Pr-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

acpi_dev_filter_resource_type() returns 0 on success, and 1 on failure.
A return value of zero means there's a matching resource, so we should
continue within setup_res() to get the resource.

Signed-off-by: Rui Wang <rui.y.wang@intel.com>
---
 drivers/acpi/ioapic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/ioapic.c b/drivers/acpi/ioapic.c
index 2449377..8ab6d42 100644
--- a/drivers/acpi/ioapic.c
+++ b/drivers/acpi/ioapic.c
@@ -46,7 +46,7 @@ static acpi_status setup_res(struct acpi_resource *acpi_res, void *data)
 	struct resource_win win;
 
 	res->flags = 0;
-	if (acpi_dev_filter_resource_type(acpi_res, IORESOURCE_MEM) == 0)
+	if (acpi_dev_filter_resource_type(acpi_res, IORESOURCE_MEM))
 		return AE_OK;
 
 	if (!acpi_dev_resource_memory(acpi_res, res)) {
-- 
1.8.3.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 3/5] x86/ioapic: Fix setup_res() failing to get resource Rui Wang <rui.y.wang@intel.com> - 2016-08-17 10:20 +0200
  [tip:x86/apic] x86/ioapic: Fix setup_res() failing to get resource tip-bot for Rui Wang <tipbot@zytor.com> - 2016-08-18 13:10 +0200

csiph-web