Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1464386
| From | Xin Long <lucien.xin@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [LKP] [lkp] [sctp] a6c2f79287: netperf.Throughput_Mbps -37.2% regression |
| Date | 2016-08-17 09:40 +0200 |
| Message-ID | <s73C9-6mv-9@gated-at.bofh.it> (permalink) |
| References | (6 earlier) <s71gZ-4UF-11@gated-at.bofh.it> <s71K1-57o-3@gated-at.bofh.it> <s71TI-5aR-13@gated-at.bofh.it> <s72mJ-5By-5@gated-at.bofh.it> <s72G6-5IV-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
> include/net/sctp/structs.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/net/sctp/structs.h b/include/net/sctp/structs.h
> index d8e464aacb20..932f2780d3a4 100644
> --- a/include/net/sctp/structs.h
> +++ b/include/net/sctp/structs.h
> @@ -602,6 +602,9 @@ struct sctp_chunk {
> /* This needs to be recoverable for SCTP_SEND_FAILED events. */
> struct sctp_sndrcvinfo sinfo;
>
> + unsigned long prsctp_param;
> + int sent_count;
> +
> /* Which association does this belong to? */
> struct sctp_association *asoc;
>
> --
> 2.5.5
>
> Then the performance dropped to the same as the bisected commit
> a6c2f792873a:
> $ cat 4.7.0-rc6-01198-g98dd2532b14e/0/netperf.json
> {
> "netperf.Throughput_Mbps": [
> 754.494375
> ]
> }
>
> I think this agrees with the perf data in that the newly added function
> doesn't show up in the perf-profile but still, the performance drops.
> So the only possible reason is the newly added fields to the sctp_chunk
> structure.
>
> Is this expected?
interesting , you didn't include the modification of the functions
parts, right ?
you mean only this two line:
> + unsigned long prsctp_param;
> + int sent_count;ca;
caused the performance issue ?
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [LKP] [lkp] [sctp] a6c2f79287: netperf.Throughput_Mbps -37.2% regression Xin Long <lucien.xin@gmail.com> - 2016-08-16 10:10 +0200
Re: [LKP] [lkp] [sctp] a6c2f79287: netperf.Throughput_Mbps -37.2% regression Aaron Lu <aaron.lu@intel.com> - 2016-08-16 10:40 +0200
Re: [LKP] [lkp] [sctp] a6c2f79287: netperf.Throughput_Mbps -37.2% regression Aaron Lu <aaron.lu@intel.com> - 2016-08-16 11:00 +0200
Re: [LKP] [lkp] [sctp] a6c2f79287: netperf.Throughput_Mbps -37.2% regression Xin Long <lucien.xin@gmail.com> - 2016-08-16 12:00 +0200
Re: [LKP] [lkp] [sctp] a6c2f79287: netperf.Throughput_Mbps -37.2% regression Aaron Lu <aaron.lu@intel.com> - 2016-08-17 07:10 +0200
Re: [LKP] [lkp] [sctp] a6c2f79287: netperf.Throughput_Mbps -37.2% regression Aaron Lu <aaron.lu@intel.com> - 2016-08-17 07:40 +0200
Re: [LKP] [lkp] [sctp] a6c2f79287: netperf.Throughput_Mbps -37.2% regression Xin Long <lucien.xin@gmail.com> - 2016-08-17 07:50 +0200
Re: [LKP] [lkp] [sctp] a6c2f79287: netperf.Throughput_Mbps -37.2% regression Aaron Lu <aaron.lu@intel.com> - 2016-08-17 08:20 +0200
Re: [LKP] [lkp] [sctp] a6c2f79287: netperf.Throughput_Mbps -37.2% regression Aaron Lu <aaron.lu@intel.com> - 2016-08-17 08:40 +0200
Re: [LKP] [lkp] [sctp] a6c2f79287: netperf.Throughput_Mbps -37.2% regression Aaron Lu <aaron.lu@intel.com> - 2016-08-17 08:50 +0200
Re: [LKP] [lkp] [sctp] a6c2f79287: netperf.Throughput_Mbps -37.2% regression Xin Long <lucien.xin@gmail.com> - 2016-08-17 09:40 +0200
Re: [LKP] [lkp] [sctp] a6c2f79287: netperf.Throughput_Mbps -37.2% regression Aaron Lu <aaron.lu@intel.com> - 2016-08-17 09:50 +0200
Re: [LKP] [lkp] [sctp] a6c2f79287: netperf.Throughput_Mbps -37.2% regression Aaron Lu <aaron.lu@intel.com> - 2016-08-17 10:00 +0200
Re: [LKP] [lkp] [sctp] a6c2f79287: netperf.Throughput_Mbps -37.2% regression Xin Long <lucien.xin@gmail.com> - 2016-08-17 10:10 +0200
Re: [LKP] [lkp] [sctp] a6c2f79287: netperf.Throughput_Mbps -37.2% regression Aaron Lu <aaron.lu@intel.com> - 2016-08-17 10:50 +0200
Re: [LKP] [lkp] [sctp] a6c2f79287: netperf.Throughput_Mbps -37.2% regression Xin Long <lucien.xin@gmail.com> - 2016-08-17 11:10 +0200
Re: [LKP] [lkp] [sctp] a6c2f79287: netperf.Throughput_Mbps -37.2% regression Aaron Lu <aaron.lu@intel.com> - 2016-08-17 11:30 +0200
Re: [LKP] [lkp] [sctp] a6c2f79287: netperf.Throughput_Mbps -37.2% regression Xin Long <lucien.xin@gmail.com> - 2016-08-17 20:10 +0200
Re: [LKP] [lkp] [sctp] a6c2f79287: netperf.Throughput_Mbps -37.2% regression Aaron Lu <aaron.lu@intel.com> - 2016-08-18 05:30 +0200
Re: [LKP] [lkp] [sctp] a6c2f79287: netperf.Throughput_Mbps -37.2% regression Xin Long <lucien.xin@gmail.com> - 2016-08-18 14:50 +0200
Re: [LKP] [lkp] [sctp] a6c2f79287: netperf.Throughput_Mbps -37.2% regression Aaron Lu <aaron.lu@intel.com> - 2016-08-19 07:30 +0200
Re: [LKP] [lkp] [sctp] a6c2f79287: netperf.Throughput_Mbps -37.2% regression Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> - 2016-08-19 09:30 +0200
Re: [LKP] [lkp] [sctp] a6c2f79287: netperf.Throughput_Mbps -37.2% regression Aaron Lu <aaron.lu@intel.com> - 2016-08-19 09:30 +0200
Re: [LKP] [lkp] [sctp] a6c2f79287: netperf.Throughput_Mbps -37.2% regression Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> - 2016-08-22 23:50 +0200
Re: [LKP] [lkp] [sctp] a6c2f79287: netperf.Throughput_Mbps -37.2% regression Aaron Lu <aaron.lu@intel.com> - 2016-08-23 11:30 +0200
Re: [LKP] [lkp] [sctp] a6c2f79287: netperf.Throughput_Mbps -37.2% regression Xin Long <lucien.xin@gmail.com> - 2016-08-17 07:40 +0200
Re: [LKP] [lkp] [sctp] a6c2f79287: netperf.Throughput_Mbps -37.2% regression Xin Long <lucien.xin@gmail.com> - 2016-08-16 20:40 +0200
csiph-web