Re: [PATCH v3 35/51] x86/unwind: add new unwind interface and implementations

From	Josh Poimboeuf <jpoimboe@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 35/51] x86/unwind: add new unwind interface and implementations
Date	2016-08-16 01:10 +0200
Message-ID	<s6zb4-3AC-17@gated-at.bofh.it> (permalink)
References	<s5lMR-2Ra-3@gated-at.bofh.it> <s5lMS-2Ra-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Aug 12, 2016 at 09:28:54AM -0500, Josh Poimboeuf wrote:
> +	/*
> +	 * The caller can optionally provide a stack pointer directly
> +	 * (sp) or indirectly (regs->sp), which indicates which stack
> +	 * frame to start unwinding at.  Skip ahead until we reach it.
> +	 */
> +	while (!unwind_done(state) &&
> +	       (!on_stack(&state->stack_info, first_sp, sizeof(*first_sp) ||
> +		state->bp < first_sp)))
> +		unwind_next_frame(state);

Ack, the parentheses got messed up with a last minute formatting change
and gcc didn't catch it.  This should actually be:

	while (!unwind_done(state) &&
	       (!on_stack(&state->stack_info, first_sp, sizeof(*first_sp)) ||
		state->bp < first_sp))
		unwind_next_frame(state);

-- 
Josh

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 35/51] x86/unwind: add new unwind interface and implementations Josh Poimboeuf <jpoimboe@redhat.com> - 2016-08-12 16:40 +0200
  Re: [PATCH v3 35/51] x86/unwind: add new unwind interface and  implementations Josh Poimboeuf <jpoimboe@redhat.com> - 2016-08-16 01:10 +0200

csiph-web