Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1463254

Re: [PATCH] android: binder: Remove deprecated create_singlethread_workqueue

Show all headers | View raw

On Sat, Aug 13, 2016 at 10:16:24PM +0530, Bhaktipriya Shridhar wrote:
> The workqueue is being used to run deferred work for the android binder.
> 
> The "binder_deferred_workqueue" queues only a single work item and hence
> does not require ordering. Also, this workqueue is not being used on a
> memory recliam path. Hence, the singlethreaded workqueue has been
> replaced with the use of system_wq.
> 
> System workqueues have been able to handle high level of concurrency
> for a long time now and hence it's not required to have a singlethreaded
> workqueue just to gain concurrency. Unlike a dedicated per-cpu workqueue
> created with create_singlethread_workqueue(), system_wq allows multiple
> work items to overlap executions even on the same CPU; however, a
> per-cpu workqueue doesn't have any CPU locality or global ordering
> guarantee unless the target CPU is explicitly specified and thus the
> increase of local concurrency shouldn't make any difference.
> 
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>

Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

-- 
tejun

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] android: binder: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-13 18:50 +0200
  Re: [PATCH] android: binder: Remove deprecated  create_singlethread_workqueue Tejun Heo <tj@kernel.org> - 2016-08-16 01:10 +0200

csiph-web