Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1463007
| From | James Bottomley <jejb@linux.vnet.ibm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 1/3] sas: provide stub implementations for scsi_is_sas_phy and sas_get_address |
| Date | 2016-08-15 19:20 +0200 |
| Message-ID | <s6tIm-8po-1@gated-at.bofh.it> (permalink) |
| References | <s6rQe-7ef-5@gated-at.bofh.it> <s6rQe-7ef-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, 2016-08-15 at 17:12 +0200, Johannes Thumshirn wrote:
> +static inline u64 sas_get_address(struct scsi_device *sdev)
> +{
> + return 0;
> +}
To be honest, we don't want this. We do want the code to fail to
compile if you ever use sas_get_address where you shouldn't because the
code will be incorrect at that point. If we could return an error,
fine, but we just return the address.
James
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH v2 1/3] sas: provide stub implementations for scsi_is_sas_phy and sas_get_address Johannes Thumshirn <jthumshirn@suse.de> - 2016-08-15 17:20 +0200 Re: [PATCH v2 1/3] sas: provide stub implementations for scsi_is_sas_phy and sas_get_address James Bottomley <jejb@linux.vnet.ibm.com> - 2016-08-15 19:20 +0200
csiph-web