Re: [PATCH] clk: qoriq: fix a register offset error

From	Scott Wood <oss@buserror.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] clk: qoriq: fix a register offset error
Date	2016-08-15 18:40 +0200
Message-ID	<s6t5D-7Vx-17@gated-at.bofh.it> (permalink)
References	<s6t5D-7Vx-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 2016-08-15 at 15:28 +0800, yuantian.tang@nxp.com wrote:
> From: Tang Yuantian <Yuantian.Tang@nxp.com>
> 
> The offset of Core Cluster clock control/status register
> on cluster group V3 version is different from others, and
> should be plus 0x70000.
> 
> Signed-off-by: Tang Yuantian <yuantian.tang@nxp.com>
> ---
>  drivers/clk/clk-qoriq.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c
> index f4c455a..05e416c 100644
> --- a/drivers/clk/clk-qoriq.c
> +++ b/drivers/clk/clk-qoriq.c
> @@ -774,7 +774,11 @@ static struct clk * __init create_one_cmux(struct
> clockgen *cg, int idx)
>  	if (!hwc)
>  		return NULL;
>  
> -	hwc->reg = cg->regs + 0x20 * idx;
> +	if (cg->info.flags & CG_VER3)
> +		hwc->reg = cg->regs + 0x70000 + 0x20 * idx;
> +	else
> +		hwc->reg = cg->regs + 0x20 * idx;
> +
>  	hwc->info = cg->info.cmux_groups[cg->info.cmux_to_group[idx]];

Reviewed-by: Scott Wood <oss@buserror.net>

-Scott

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] clk: qoriq: fix a register offset error Scott Wood <oss@buserror.net> - 2016-08-15 18:40 +0200

csiph-web