Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1462882

Re: [PATCH v3 09/13] sched/fair: Let asymmetric cpu configurations balance at wake-up

Show all headers | View raw

On Mon, Aug 15, 2016 at 04:01:34PM +0100, Morten Rasmussen wrote:
> On Mon, Aug 15, 2016 at 03:39:49PM +0200, Peter Zijlstra wrote:
> > > +static int wake_cap(struct task_struct *p, int cpu, int prev_cpu)
> > > +{
> > > +	long min_cap, max_cap;
> > > +
> > > +	min_cap = min(capacity_orig_of(prev_cpu), capacity_orig_of(cpu));
> > > +	max_cap = cpu_rq(cpu)->rd->max_cpu_capacity;
> > 
> > There's a tiny hole here, which I'm fairly sure we don't care about. If
> > @p last ran on @prev_cpu before @prev_cpu was split from @rd this
> > doesn't 'work' right.
> 
> I hadn't considered that. What is 'working right' in this scenario?
> Ignoring @prev_cpu as it isn't a valid option anymore?

Probably, yeah.

> In that case, since @prev_cpu is only used as part the min() it should
> only cause min_cap to be potentially smaller than it should be, not
> larger. It could lead us to let BALANCE_WAKE take over in scenarios
> where select_idle_sibling() would have been sufficient, but it should
> harm.

+not, right?

> However, as you say, I'm not sure if we care that much.

Yeah, don't think so, its extremely unlikely to happen, almost nobody
mucks about with root_domains anyway. And those that do, do so once to
setup things and then leave them be.

> Talking about @rd, I discussed with Juri and Dietmar the other week
> whether the root_domain is RCU protected, and if we therefore have to
> move the call to wake_cap() after the rcu_read_lock() below. I haven't
> yet done thorough investigation to find the answer. Should it be
> protected?

Yeah, I think either RCU or RCU-sched, I forever forget.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 09/13] sched/fair: Let asymmetric cpu configurations  balance at wake-up Peter Zijlstra <peterz@infradead.org> - 2016-08-15 15:50 +0200
  Re: [PATCH v3 09/13] sched/fair: Let asymmetric cpu configurations  balance at wake-up Morten Rasmussen <morten.rasmussen@arm.com> - 2016-08-15 17:10 +0200
    Re: [PATCH v3 09/13] sched/fair: Let asymmetric cpu configurations  balance at wake-up Peter Zijlstra <peterz@infradead.org> - 2016-08-15 17:20 +0200
      Re: [PATCH v3 09/13] sched/fair: Let asymmetric cpu configurations  balance at wake-up Morten Rasmussen <morten.rasmussen@arm.com> - 2016-08-15 17:40 +0200

csiph-web