Re: [PATCH 1/1] x86/apic: Introduce paravirq irq_domain

From	Paolo Bonzini <pbonzini@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1] x86/apic: Introduce paravirq irq_domain
Date	2016-08-15 14:40 +0200
Message-ID	<s6plo-5AL-55@gated-at.bofh.it> (permalink)
References	(2 earlier) <s5ilY-yH-7@gated-at.bofh.it> <s5j8l-16d-5@gated-at.bofh.it> <s5sOl-7GA-13@gated-at.bofh.it> <s5ACd-5tQ-1@gated-at.bofh.it> <s6oyZ-537-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 15/08/2016 13:51, Alexander Popov wrote:
> On 13.08.2016 09:20, Paolo Bonzini wrote:
>> On 13/08/2016 00:07, Alexander Popov wrote:
>>> I.e. our irq_mask()/irq_unmask() callbacks get irq_desc of the interrupt
>>> which should be masked/unmasked and can ask the hypervisor to stop/start
>>> injecting the vector of that particular interrupt.
>>
>> So just let the irqdomain know about your hypervisor and avoid the
>> pointless indirection through function pointers, and only call
>> arch_init_paravirq_domain in a file specific to your hypervisor.
> 
> Paolo, I would like paravirq irq_domain to be useful for many hypervisors,
> not only for one developed by Positive Technologies.

If somebody else comes up with similar needs, leave the generalization
of the code to them.  The maintainers will surely remember.  Without two
users, there's a nonzero chance that the abstraction you have is not
good enough, and actually gets in the way of the "second user".

> It seems to me that the idea of an irq_domain for interrupts injected
> by a hypervisor is quite generic.

True, but all of Xen, KVM and VMware use PCI devices for this.

Paolo

Thread

[PATCH 1/1] x86/apic: Introduce paravirq irq_domain Alexander Popov <alex.popov@linux.com> - 2016-08-11 16:10 +0200
  Re: [PATCH 1/1] x86/apic: Introduce paravirq irq_domain Paolo Bonzini <pbonzini@redhat.com> - 2016-08-11 18:50 +0200
    Re: [PATCH 1/1] x86/apic: Introduce paravirq irq_domain Alexander Popov <alex.popov@linux.com> - 2016-08-12 13:00 +0200
      Re: [PATCH 1/1] x86/apic: Introduce paravirq irq_domain Paolo Bonzini <pbonzini@redhat.com> - 2016-08-12 13:50 +0200
        Re: [PATCH 1/1] x86/apic: Introduce paravirq irq_domain Alexander Popov <alex.popov@linux.com> - 2016-08-13 00:10 +0200
          Re: [PATCH 1/1] x86/apic: Introduce paravirq irq_domain Paolo Bonzini <pbonzini@redhat.com> - 2016-08-13 08:30 +0200
            Re: [PATCH 1/1] x86/apic: Introduce paravirq irq_domain Alexander Popov <alex.popov@linux.com> - 2016-08-15 13:50 +0200
              Re: [PATCH 1/1] x86/apic: Introduce paravirq irq_domain Paolo Bonzini <pbonzini@redhat.com> - 2016-08-15 14:40 +0200
                Re: [PATCH 1/1] x86/apic: Introduce paravirq irq_domain Alexander Popov <alex.popov@linux.com> - 2016-08-16 22:00 +0200
                Re: [PATCH 1/1] x86/apic: Introduce paravirq irq_domain Jan Kiszka <jan.kiszka@siemens.com> - 2016-08-17 16:40 +0200
                Re: [PATCH 1/1] x86/apic: Introduce paravirq irq_domain Alexander Popov <alex.popov@linux.com> - 2016-08-18 01:00 +0200
                Re: [PATCH 1/1] x86/apic: Introduce paravirq irq_domain Jan Kiszka <jan.kiszka@siemens.com> - 2016-08-19 13:00 +0200

csiph-web