[PATCH] net: hns: mdio->irq is an array, so no need to check if it is null

From	Colin King <colin.king@canonical.com>
Newsgroups	linux.kernel
Subject	[PATCH] net: hns: mdio->irq is an array, so no need to check if it is null
Date	2016-08-15 15:00 +0200
Message-ID	<s6pEJ-5I5-7@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Colin Ian King <colin.king@canonical.com>

The null check on mdio->irq is redundant since mdio->irq is an array
of PHY_MAX_ADDR ints and hence can never be null. Remove the redundant
check.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c
index 5c8afe1..a834774 100644
--- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c
+++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c
@@ -684,8 +684,7 @@ hns_mac_register_phydev(struct mii_bus *mdio, struct hns_mac_cb *mac_cb,
 	if (!phy || IS_ERR(phy))
 		return -EIO;
 
-	if (mdio->irq)
-		phy->irq = mdio->irq[addr];
+	phy->irq = mdio->irq[addr];
 
 	/* All data is now stored in the phy struct;
 	 * register it
-- 
2.8.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] net: hns: mdio->irq is an array, so no need to check if it is null Colin King <colin.king@canonical.com> - 2016-08-15 15:00 +0200
  Re: [PATCH] net: hns: mdio->irq is an array, so no need to check  if it is null David Miller <davem@davemloft.net> - 2016-08-15 22:40 +0200

csiph-web