Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1462704
| From | Will Deacon <will.deacon@arm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] perf/core: Don't pass PERF_EF_START to the PMU ->start callback |
| Date | 2016-08-15 12:50 +0200 |
| Message-ID | <s6nCV-4sn-7@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
PERF_EF_START is a flag to indicate to the PMU ->add callback that, as well as claiming the PMU resources required by the event being added, it should also start the PMU. Passing this flag to the ->start callback doesn't make sense, because ->start always tries to start the PMU. Remove it. Cc: Peter Zijlstra <peterz@infradead.org> Signed-off-by: Will Deacon <will.deacon@arm.com> --- kernel/events/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/events/core.c b/kernel/events/core.c index 1903b8f3a705..b11504376af7 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -2455,7 +2455,7 @@ static int __perf_event_stop(void *info) * while restarting. */ if (sd->restart) - event->pmu->start(event, PERF_EF_START); + event->pmu->start(event, 0); return 0; } -- 2.1.4
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH] perf/core: Don't pass PERF_EF_START to the PMU ->start callback Will Deacon <will.deacon@arm.com> - 2016-08-15 12:50 +0200
csiph-web