Re: [PATCH v3 4/4] arm64: apply __ro_after_init to some objects

From	Mark Rutland <mark.rutland@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 4/4] arm64: apply __ro_after_init to some objects
Date	2016-08-15 11:10 +0200
Message-ID	<s6m4a-3Ev-19@gated-at.bofh.it> (permalink)
References	<s5fHr-7yv-5@gated-at.bofh.it> <s5fHr-7yv-3@gated-at.bofh.it> <s5k4q-1GM-11@gated-at.bofh.it> <s6k2l-290-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

On Mon, Aug 15, 2016 at 02:53:03PM +0800, Jisheng Zhang wrote:
> On Fri, 12 Aug 2016 13:43:45 +0100 Mark Rutland wrote:
> > On Fri, Aug 12, 2016 at 04:01:11PM +0800, Jisheng Zhang wrote:
> > > diff --git a/arch/arm64/kernel/vdso.c b/arch/arm64/kernel/vdso.c
> > > index 10ad8ab..c1ff7c2 100644
> > > --- a/arch/arm64/kernel/vdso.c
> > > +++ b/arch/arm64/kernel/vdso.c
> > > @@ -19,6 +19,7 @@
> > >   */
> > >  
> > >  #include <linux/kernel.h>
> > > +#include <linux/cache.h>
> > >  #include <linux/clocksource.h>
> > >  #include <linux/elf.h>
> > >  #include <linux/err.h>  
> > 
> > Nit: Could you please sort this list? Everything but <linux/kernel.h> is
> > already in order.

[...]

> Thanks a lot, all comments are addressed in v4.
> 
> the headers in vdso.c is sorted now. However, the headers in mmu.c,
> dma-mapping.c, init.c aren't, for I dunno whether it's acceptable
> to do so. Or we could add one separate patch to make them sorted before
> applying __ro_after_init

Ah. Given that's a little messy, it's probably not worthwhile sorting them.
Further, feel free to not bother sorting the vdso.c includes.

Thanks,
Mark.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 4/4] arm64: apply __ro_after_init to some objects Jisheng Zhang <jszhang@marvell.com> - 2016-08-12 10:10 +0200
  Re: [PATCH v3 4/4] arm64: apply __ro_after_init to some objects Mark Rutland <mark.rutland@arm.com> - 2016-08-12 14:50 +0200
    Re: [PATCH v3 4/4] arm64: apply __ro_after_init to some objects Jisheng Zhang <jszhang@marvell.com> - 2016-08-15 09:00 +0200
      Re: [PATCH v3 4/4] arm64: apply __ro_after_init to some objects Mark Rutland <mark.rutland@arm.com> - 2016-08-15 11:10 +0200

csiph-web