Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1462606

Re: [PATCH v5 02/13] kexec_file: Change kexec_add_buffer to take kexec_buf as argument.

Show all headers | View raw

On Thu, Aug 11, 2016 at 08:08:07PM -0300, Thiago Jung Bauermann wrote:
> Adapt all callers to the new function prototype.
>

Could you please expand on this?
 
> In addition, change the type of kexec_buf.buffer from char * to void *.
> There is no particular reason for it to be a char *, and the change
> allows us to get rid of 3 existing casts to char * in the code.
> 
> Signed-off-by: Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com>
> Acked-by: Dave Young <dyoung@redhat.com>
> ---

Looks good otherwise

Acked-by: Balbir Singh <bsingharora@gmail.com>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v5 02/13] kexec_file: Change kexec_add_buffer to take kexec_buf as argument. Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com> - 2016-08-12 01:10 +0200
  Re: [PATCH v5 02/13] kexec_file: Change kexec_add_buffer to take  kexec_buf as argument. Balbir Singh <bsingharora@gmail.com> - 2016-08-15 09:40 +0200
    Re: [PATCH v5 02/13] kexec_file: Change kexec_add_buffer to take kexec_buf as argument. Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com> - 2016-08-15 17:00 +0200
      Re: [PATCH v5 02/13] kexec_file: Change kexec_add_buffer to take  kexec_buf as argument. Balbir Singh <bsingharora@gmail.com> - 2016-08-16 08:20 +0200
        Re: [PATCH v5 02/13] kexec_file: Change kexec_add_buffer to take kexec_buf as argument. Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com> - 2016-08-16 21:00 +0200
          Re: [PATCH v5 02/13] kexec_file: Change kexec_add_buffer to take  kexec_buf as argument. Balbir Singh <bsingharora@gmail.com> - 2016-08-17 04:10 +0200

csiph-web