[PATCH] drm/nouveau/tegra: Modify error handling

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Amitoj Kaur Chawla <amitoj1606@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] drm/nouveau/tegra: Modify error handling
Date	Mon, 15 Aug 2016 07:00:01 +0200
Message-ID	<s6iad-We-9@gated-at.bofh.it> (permalink)
X-Original-To	bskeggs@redhat.com, airlied@linux.ie, swarren@wwwdotorg.org, thierry.reding@gmail.com, gnurou@gmail.com, dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=F42CYIKIoc73e0XP07FZ8RDUEZfbZjxzouUrXYnDK4Q=; b=ko5AZ93Uk51ERt9EBgh7pRyItU2LQMAWCdGOuvAcalTBBoJQGbt9522hHeLorDNrmT XorP+FCmPIR5zHihDNck4QyvDw4NIGvLsWDJCeq76dgNAauyRN4bE8Vbku6nDDhUxziu XXuSw5pCVC8oZTANLtQ2sEWiwATk0xXuiabpmZS3X4oZmWl0f6vI2wDlMA/8GNcFCEZu 2A8hKMW6cpvBvtyLSTolf2HgNYVBcor5aniEk9b8mKy9Z4NUXYASFR3cfY8adcMCWEuF 7lxtH4FGioY7qiLiaCF0PO/3FBMKVmDnih9bA7Cj1yyuQojILIDMGFaqCPIAs9DaDnFW wggA==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=F42CYIKIoc73e0XP07FZ8RDUEZfbZjxzouUrXYnDK4Q=; b=NYEuL7HHq+EVB4WTcimtItZlY9mMTbkKe2sMmQYcyobTfT2+Un7pyT+BcOvRcpXqWX zti/zkzJt2Ktb1NMKhQy0LfPMttD2/eLe20DObkzZKS1jypzVpOm0EUKh18flEy3db6k entn+S9V95TbTsMTfPZit5wR1gKNhKkzZEZxseWTKptubLGHpfkL9pJRhKS3N1qMMKZb D85CYOTBriHtCuGqn6pmlOv7lZ0XEhGUSZ3Q9NjET115+pnkVTg0SERJ8maAT+pMVex8 uPI7uYz/Gsu9ABWklF4eN6e9E3jR81Ehd606fWoQ+iPox819roZF6tdZAS+TIxndfy9+ wTiw==
X-Gm-Message-State	AEkoouvNBI9eSq1zONQYANV7aOKlNxMUpzhn8Ah8giKa0+bDuB/uHB/WUee3G6hTd+xl6w==
X-Received	by 10.98.85.134 with SMTP id j128mr50955118pfb.6.1471236853865; Sun, 14 Aug 2016 21:54:13 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	32
Organization	linux.* mail to news gateway
X-Original-Cc	julia.lawall@lip6.fr
X-Original-Date	Mon, 15 Aug 2016 10:24:09 +0530
X-Original-Message-ID	<20160815045409.GA12886@amitoj-Inspiron-3542>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1462549

Show key headers only | View raw

iommu_domain_alloc returns NULL on error so replace an incorrect
IS_ERR check with a NULL check.

The Coccinelle semantic patch used to find this issue is as follows:
@@
expression e;
statement S;
@@

*e = iommu_domain_alloc(...);
if (IS_ERR(e)) S

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
 drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c b/drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c
index 939682f..ffd8def 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c
@@ -102,7 +102,7 @@ nvkm_device_tegra_probe_iommu(struct nvkm_device_tegra *tdev)
 
 	if (iommu_present(&platform_bus_type)) {
 		tdev->iommu.domain = iommu_domain_alloc(&platform_bus_type);
-		if (IS_ERR(tdev->iommu.domain))
+		if (!tdev->iommu.domain)
 			goto error;
 
 		/*
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] drm/nouveau/tegra: Modify error handling Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2016-08-15 07:00 +0200
  Re: [PATCH] drm/nouveau/tegra: Modify error handling Alexandre Courbot <gnurou@gmail.com> - 2016-08-23 19:30 +0200

csiph-web