Re: [PATCH v2 0/5] bug: Provide toggle for BUG on data corruption

From	Kees Cook <keescook@chromium.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 0/5] bug: Provide toggle for BUG on data corruption
Date	2016-08-17 05:40 +0200
Message-ID	<s6ZRT-3Oc-5@gated-at.bofh.it> (permalink)
References	<s6WU2-1Ld-3@gated-at.bofh.it> <s6Xn3-1XO-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Aug 16, 2016 at 5:55 PM, Henrique de Moraes Holschuh
<hmh@hmh.eng.br> wrote:
> On Tue, 16 Aug 2016, Kees Cook wrote:
>> This adds a CONFIG to trigger BUG()s when the kernel encounters
>> unexpected data structure integrity as currently detected with
>> CONFIG_DEBUG_LIST.
>>
>> Specifically list operations have been a target for widening flaws to gain
>> "write anywhere" primitives for attackers, so this also consolidates the
>> debug checking to avoid code and check duplication (e.g. RCU list debug
>> was missing a check that got added to regular list debug). It also stops
>> manipulations when corruption is detected, since worsening the corruption
>> makes no sense. (Really, everyone should build with CONFIG_DEBUG_LIST
>> since the checks are so inexpensive.)
>
> Well, maybe it wants a name that it looks like something that should be
> enabled by default on production kernels?
>
> I.e. CONFIG_DETECT_LIST_CORRUPTION or somesuch?

Yeah, that very well be true. I'd currently like to avoid CONFIG name
churn, but I've added it to my list of CONFIGs to rename (along with
CONFIG_DEBUG_RODATA). :)

-Kees

-- 
Kees Cook
Nexus Security

Thread

[PATCH v2 0/5] bug: Provide toggle for BUG on data corruption Kees Cook <keescook@chromium.org> - 2016-08-17 02:30 +0200
  [PATCH v2 1/5] list: Split list_add() debug checking into separate function Kees Cook <keescook@chromium.org> - 2016-08-17 02:30 +0200
    Re: [PATCH v2 1/5] list: Split list_add() debug checking into  separate function Steven Rostedt <rostedt@goodmis.org> - 2016-08-17 15:20 +0200
  [PATCH v2 2/5] rculist: Consolidate DEBUG_LIST for list_add_rcu() Kees Cook <keescook@chromium.org> - 2016-08-17 02:30 +0200
  Re: [PATCH v2 4/5] bug: Provide toggle for BUG on data corruption Joe Perches <joe@perches.com> - 2016-08-17 02:30 +0200
    Re: [PATCH v2 4/5] bug: Provide toggle for BUG on data corruption Kees Cook <keescook@chromium.org> - 2016-08-17 05:40 +0200
  [PATCH v2 5/5] lkdtm: Add tests for struct list corruption Kees Cook <keescook@chromium.org> - 2016-08-17 02:30 +0200
  [PATCH v2 4/5] bug: Provide toggle for BUG on data corruption Kees Cook <keescook@chromium.org> - 2016-08-17 02:50 +0200
    Re: [PATCH v2 4/5] bug: Provide toggle for BUG on data corruption Steven Rostedt <rostedt@goodmis.org> - 2016-08-17 15:30 +0200
  [PATCH v2 3/5] list: Split list_del() debug checking into separate function Kees Cook <keescook@chromium.org> - 2016-08-17 02:50 +0200
  Re: [PATCH v2 0/5] bug: Provide toggle for BUG on data corruption Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2016-08-17 03:00 +0200
    Re: [PATCH v2 0/5] bug: Provide toggle for BUG on data corruption Kees Cook <keescook@chromium.org> - 2016-08-17 05:40 +0200
  Re: [PATCH v2 0/5] bug: Provide toggle for BUG on data corruption Stephen Boyd <sboyd@codeaurora.org> - 2016-08-17 22:20 +0200
    Re: [PATCH v2 0/5] bug: Provide toggle for BUG on data corruption Kees Cook <keescook@chromium.org> - 2016-08-17 23:20 +0200

csiph-web