Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1464282
| From | Xunlei Pang <xlpang@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v2 2/2] kexec: Consider crashk_low_res in sanity_check_segment_list() |
| Date | 2016-08-17 04:00 +0200 |
| Message-ID | <s6Yj7-2C8-7@gated-at.bofh.it> (permalink) |
| References | <s6Yj7-2C8-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
We have crashk_res only in most cases, but sometimes we have crashk_low_res. For example, on 64-bit x86 systems, when "crashkernel=32M,high" combined with "crashkernel=128M,low" is used, so some segments may have the chance to be loaded into crashk_low_res area. We can't fail it as a memory violation in these cases. Thus, we add the case to regard the segment as valid if it is within crashk_low_res. Signed-off-by: Xunlei Pang <xlpang@redhat.com> --- kernel/kexec_core.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c index 707d18e..9012a60 100644 --- a/kernel/kexec_core.c +++ b/kernel/kexec_core.c @@ -248,9 +248,14 @@ int sanity_check_segment_list(struct kimage *image) mstart = image->segment[i].mem; mend = mstart + image->segment[i].memsz - 1; /* Ensure we are within the crash kernel limits */ - if ((mstart < phys_to_boot_phys(crashk_res.start)) || - (mend > phys_to_boot_phys(crashk_res.end))) - return -EADDRNOTAVAIL; + if ((mstart >= phys_to_boot_phys(crashk_res.start)) && + (mend <= phys_to_boot_phys(crashk_res.end))) + continue; + if ((mstart >= phys_to_boot_phys(crashk_low_res.start)) && + (mend <= phys_to_boot_phys(crashk_low_res.end))) + continue; + + return -EADDRNOTAVAIL; } } -- 1.8.3.1
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 1/2] kexec: Introduce "/sys/kernel/kexec_crash_low_size" Xunlei Pang <xlpang@redhat.com> - 2016-08-17 04:00 +0200
[PATCH v2 2/2] kexec: Consider crashk_low_res in sanity_check_segment_list() Xunlei Pang <xlpang@redhat.com> - 2016-08-17 04:00 +0200
Re: [PATCH v2 2/2] kexec: Consider crashk_low_res in sanity_check_segment_list() Dave Young <dyoung@redhat.com> - 2016-08-17 09:30 +0200
Re: [PATCH v2 2/2] kexec: Consider crashk_low_res in sanity_check_segment_list() Xunlei Pang <xpang@redhat.com> - 2016-08-17 09:50 +0200
Re: [PATCH v2 1/2] kexec: Introduce "/sys/kernel/kexec_crash_low_size" Dave Young <dyoung@redhat.com> - 2016-08-17 10:30 +0200
Re: [PATCH v2 1/2] kexec: Introduce "/sys/kernel/kexec_crash_low_size" Yinghai Lu <yinghai@kernel.org> - 2016-08-24 03:20 +0200
Re: [PATCH v2 1/2] kexec: Introduce "/sys/kernel/kexec_crash_low_size" Dave Young <dyoung@redhat.com> - 2016-08-24 10:30 +0200
Re: [PATCH v2 1/2] kexec: Introduce "/sys/kernel/kexec_crash_low_size" Xunlei Pang <xpang@redhat.com> - 2016-08-24 13:50 +0200
csiph-web