Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1463974

Re: [PATCH v2] ARM: Add missing newline terminators to kernel messages

Show all headers | View raw

Hi Joe,

On Tue, Aug 16, 2016 at 7:08 PM, Joe Perches <joe@perches.com> wrote:
> On Tue, 2016-08-16 at 15:40 +0200, Geert Uytterhoeven wrote:
>> Before commit 874f9c7da9a4acbc ("printk: create pr_<level> functions"),
>> pr_*() calls without a trailing newline characters would be printed with
>> a newline character appended, both on the console and in the output of
>> the dmesg command.
>
> Hey Geert.
>
> This doesn't apply to -next as the pr_notice/pr_cont below is
> properly changed to a single pr_notice.

In which -next?

Not in next-20160816, where the patch applies cleanly.
Also not in arm/for-next.

>> diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c
>
> []
>> @@ -1196,7 +1196,7 @@ void __init sanity_check_meminfo(void)
>>                               pr_notice("Truncating RAM at %pa-%pa",
>>                                         &block_start, &block_end);
>>                               block_end = vmalloc_limit;
>> -                             pr_cont(" to -%pa", &block_end);
>> +                             pr_cont(" to -%pa\n", &block_end);
>>                               memblock_remove(vmalloc_limit, overlap_size);
>>                               should_use_highmem = true;

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] ARM: Add missing newline terminators to kernel messages Geert Uytterhoeven <geert+renesas@glider.be> - 2016-08-16 15:50 +0200
  Re: [PATCH v2] ARM: Add missing newline terminators to kernel  messages Joe Perches <joe@perches.com> - 2016-08-16 19:10 +0200
    Re: [PATCH v2] ARM: Add missing newline terminators to kernel messages Geert Uytterhoeven <geert@linux-m68k.org> - 2016-08-16 20:00 +0200
      Re: [PATCH v2] ARM: Add missing newline terminators to kernel messages Geert Uytterhoeven <geert@linux-m68k.org> - 2016-08-16 20:10 +0200
      Re: [PATCH v2] ARM: Add missing newline terminators to kernel  messages Joe Perches <joe@perches.com> - 2016-08-16 20:10 +0200
  Re: [PATCH v2] ARM: Add missing newline terminators to kernel  messages Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-08-16 21:20 +0200
    Re: [PATCH v2] ARM: Add missing newline terminators to kernel messages Geert Uytterhoeven <geert@linux-m68k.org> - 2016-08-16 22:30 +0200

csiph-web