Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1463902

Re: RFC: callchain showing same entry as hist_entry

From Arnaldo Carvalho de Melo <acme@kernel.org>
Newsgroups linux.kernel
Subject Re: RFC: callchain showing same entry as hist_entry
Date 2016-08-16 17:50 +0200
Message-ID <s6OMN-4U7-11@gated-at.bofh.it> (permalink)
References (2 earlier) <s6OjL-4IB-21@gated-at.bofh.it> <s6Ots-4M4-21@gated-at.bofh.it> <s6OD8-4QG-1@gated-at.bofh.it> <s6OD8-4QG-9@gated-at.bofh.it> <s6OMN-4U7-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Em Wed, Aug 17, 2016 at 12:41:18AM +0900, Namhyung Kim escreveu:
> On Tue, Aug 16, 2016 at 12:32:44PM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Tue, Aug 16, 2016 at 12:31:43PM -0300, Arnaldo Carvalho de Melo escreveu:
> > > Em Wed, Aug 17, 2016 at 12:23:55AM +0900, Namhyung Kim escreveu:
> > > > Did you run 'perf report -s sym --stdio'?  It seems that current code
> > > > already works as sane..  Do you want to make it work for the default sort
> > > >> key too?
> > > 
> > > What I want is not to repeat the hist_entry line as the first entry in
> > > the callchain, which is confusing.
> > > 
> > > I.e. repeat the duplication that is happening with the default sort
> > 
> > s/repeat/remove/g
> > 
> > > entry, that contains "sym".
> 
> Hmm.. if so, wouldn't it be better skipping the first callchain entry
> when the user-given sort key contains "sym" too (not only when it
> starts with 'sym')?

Probably, I think, whatever causes the mentioned duplication. And do
that at all the UIs, hence the suggestion for a callchain__first_node()
or more suitably named routine where such logic would live, to be
used for all the callchain rendering interfaces.

- Arnaldo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

RFC: callchain showing same entry as hist_entry Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-08-16 16:40 +0200
  Re: RFC: callchain showing same entry as hist_entry Jiri Olsa <jolsa@redhat.com> - 2016-08-16 17:00 +0200
  Re: RFC: callchain showing same entry as hist_entry Namhyung Kim <namhyung@kernel.org> - 2016-08-16 17:00 +0200
    Re: RFC: callchain showing same entry as hist_entry Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-08-16 17:20 +0200
      Re: RFC: callchain showing same entry as hist_entry Namhyung Kim <namhyung@kernel.org> - 2016-08-16 17:30 +0200
        Re: RFC: callchain showing same entry as hist_entry Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-08-16 17:40 +0200
          Re: RFC: callchain showing same entry as hist_entry Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-08-16 17:40 +0200
            Re: RFC: callchain showing same entry as hist_entry Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-08-16 17:50 +0200
              Re: RFC: callchain showing same entry as hist_entry Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-08-16 21:30 +0200
                Re: RFC: callchain showing same entry as hist_entry Namhyung Kim <namhyung@kernel.org> - 2016-08-19 04:30 +0200
            Re: RFC: callchain showing same entry as hist_entry Namhyung Kim <namhyung@kernel.org> - 2016-08-16 17:50 +0200

csiph-web